Stop using NOW_URL #76
Conversation
...which was removed in Now 2.0. Instead use NOW_REGION to detect now and pull URL from x-now-deployment-url request header when needed.
This shows a page w/ no releases instead of throwing an error if there are none (or none matching our filtering) on GitHub.
You can't modify routes.js otherwise.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/zeit/hazel/mo49an80a |
...by just tacking "https://" onto the front of it for now
|
What's the status of getting this merged? I have other fixes and improvements I'd like to PR but they build on this. Thanks! |
|
Really need this fix. I thought I could use this to serve downloads to others, but it just forwards to github and gets a 404 because they’re not signed into a GH account with access. |
|
CAN SOMEONE OF YOU STUPID CREATOR PIECES OF SHIT PULL THIS PR I FUCKING HATE THAT HAZEL IS ADVERTISED IN OFFICIAL ELECTRON DOCS WHILE HAZEL DOESNT EVEN WORK ON PRIVATE REPOS!!!!!!!!!!!!!! FUCKING DELETE THIS REPO IF YOU DUMB TRASHES ABANDONED THE PROJECT |
|
Please merge this PR. I need this fix. |
|
Hey @cap10morgan! I would love to get this PR on Peanut. |
|
@ricardodantas Feel free to bring it over. I no longer work for the company that had this need and I'm no longer using Hazel / NOW / Peanut. |
|
Closing this because it's been ignored for over a year. |
NOW_URLis no longer set in Now 2.0 (ref: https://zeit.co/docs/v2/advanced/platform/changes-in-now-2-0/#environment-variables), so this should have been removed in the migration to Now 2.0. Instead this code now relies onNOW_REGIONbeing set to detect Now deployments and gets the Now URL from thex-now-deployment-urlrequest header when needed.Also standardizes how the GitHub token is used to always be in the
Authorizationrequest header and fixes a crasher bug when there are no releases on GitHub.It also passes
--passWithNoTeststo theyarn testcall in the precommit hook or it wouldn't allow me to commit the fix inroutes.jswithout creating a whole new test file for it.Fixes #62 & #39 without the need to manually set URL to an insecure value containing your GitHub access token.