Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Vercel and GitHub Private Repo (#62 #39) #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

backroot
Copy link

@backroot backroot commented Oct 4, 2020

@vercel
Copy link

vercel bot commented Oct 4, 2020

@backroot is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@backroot backroot force-pushed the support-for-vercel branch 4 times, most recently from d068710 to b232ee3 Compare October 4, 2020 07:57
@kotapeter
Copy link

@leo Can you check this pull request please? It looks promising

@backroot
Copy link
Author

backroot commented Oct 8, 2020

@leo Can you check this pull request please? It looks promising

@kotapeter Thank you for your support !

@ibash
Copy link

ibash commented Oct 29, 2020

For what it's worth I tried this branch out and it broke updates for me.
Specifically instead of download the zip (like electron expects) it was serving the app-update.yml.
The error I received from the autoupdater was ditto: Couldn't read PKZip signature.

@backroot
Copy link
Author

@ibash
Thank you for your feedback !
I will try to fix it .

@@ -6,11 +6,11 @@ module.exports = fileName => {

if (
(fileName.includes('mac') || fileName.includes('darwin')) &&
extension === 'zip'
(extension === 'yml')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@backroot curious what this change is for?

@@ -142,6 +146,18 @@ module.exports = ({ cache, config }) => {
return
}

if (targetFile) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this change for?

@GitMurf
Copy link

GitMurf commented Oct 20, 2023

Is this repo abandoned? very frustrating when Electron official docs recommend using it but looks non maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants