fix: upgrade to [email protected] to fix minfy with negated in statements

[byCedric]

Fixes #1193

[styfle]

Thanks for the PR! Looks like CI is failing however.

https://github.com/vercel/ncc/actions/runs/9369710285/job/25854934076?pr=1194#step:9:335

[byCedric]

These are interesting failures, I'm not sure why Node 20 on Ubuntu causes that error, while Node 20 on Windows seems fine.

The MacOS errors are just node-gyp (install) related issues, likely due to the GHA runner missing some low-level dependency. It's also erroring on node-canvas which isn't touched in this PR.

Edit: yeah, the macos failures are definitely related to missing system dependencies:

[byCedric]

Also interesting here is that the last run on workflow (4 months ago) did not succeed for Node 20 on Ubuntu (this run). Unfortunately, the logs have been wiped already, but that might be a pointer to this failure too.

I'm also guessing the macos-latest runner has been changed within 4 months, causing the CI failures.

[styfle]

I see what you mean. I'll run CI against main to see how it compares:

• temp ci run #1195

[byCedric]

Glad you could repro this on main (as in, not caused by this PR) 😄

Anything I can do to help?

[styfle]

I think we need to fix main before merging this to confirm it works as expected

[theoludwig]

I think we need to fix main before merging this to confirm it works as expected

What was the problem with CI (the logs disappeared)? Should probably run CI again, with all the depdencies updated to their latest version, to see the status of the project.

[styfle]

@theoludwig Feel free to create a new PR to fix it

[theoludwig]

@theoludwig Feel free to create a new PR to fix it

Alright. 😄 #1213

Tests are working locally, but about CI, I don't know, need an approval to run it. Hopefully, it fixes the issue, and allow to update terser and webpack to latest version to get latest fixes like this one with negated in statements.