Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): improve visual appearance of badges in README.md #67254

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

creativoma
Copy link
Contributor

@creativoma creativoma commented Jun 27, 2024

Description

This Pull Request improves the visual appearance of the badges in the README.md file by removing unnecessary line breaks between the badge images, eliminating the unwanted blue link lines that previously appeared and resulting in a cleaner and more cohesive look.

What

Removed unnecessary line breaks between badge images in the README.md file to eliminate the unwanted blue link lines and improve the overall visual presentation.

Why

Previously, the badges were displayed with line breaks between them, causing blue link lines to appear, which disrupted the clean look of the badges. By removing these line breaks, the badges now appear without the blue link lines, providing a more cohesive and visually appealing README.

How

  • Removed the line breaks between badge images in the README.md file.

This Pull Request improves the visual appearance of the badges in the README.md file by removing unnecessary line breaks between the badge images, eliminating the unwanted blue link lines that previously appeared and resulting in a cleaner and more cohesive look.
@ijjk
Copy link
Member

ijjk commented Jun 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 18d5d7a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@devjiwonchoi devjiwonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Add-up info:

Since GitHub adds underline by default on the links, the gap between the img and a is leaving a trailing blue underline.

@devjiwonchoi devjiwonchoi enabled auto-merge (squash) June 28, 2024 07:27
@devjiwonchoi devjiwonchoi merged commit a7faeb0 into vercel:canary Jun 28, 2024
33 checks passed
@devjiwonchoi
Copy link
Contributor

For the future readers:

Notice the blue underline below the tags

Before:

Screenshot 2024-06-28 at 4 31 22 PM

After:

Screenshot 2024-06-28 at 4 30 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants