feat(image-optimizer): use previously cached image cache entry if upstream image is identical #67257
+223
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
kahlstrm
commented
Jun 27, 2024
| // See https://en.wikipedia.org/wiki/Base64#Filenames | ||
| return hash.digest('base64').replace(/\//g, '-') | ||
| // See https://en.wikipedia.org/wiki/Base64#URL_applications | ||
| return hash.digest('base64url') |
There was a problem hiding this comment.
Not necessary for the PR, but while the CACHE_VERSION is anyways changing, it doesn't hurt? 🤷
kahlstrm
commented
Jun 27, 2024
| isStatic: boolean, | ||
| xCache: XCacheHeader, | ||
| imagesConfig: ImageConfigComplete, | ||
| maxAge: number, | ||
| isDev: boolean | ||
| ) { | ||
| const contentType = getContentType(extension) | ||
| const etag = getHash([buffer]) |
There was a problem hiding this comment.
If we are storing the etag already, shouldn't we use that instead of recalculating the etag? This can be reverted to use getImageTag.
…tream image is identical
kahlstrm
force-pushed
the
feat/use-previous-cache-entry-if-same-upstream-image
branch
from
bda2f1a
to
a1f627d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
getHash-function to returnbase64urlinstead of custom variant of standardbase64. This can be removed if deemed not necessary.getImageEtag-function to do it) to happen insideimage-optimizerfor better consistency.Why?
Currently when an image is requested and it becomes stale, the server will trigger a full image optimization for that image, using a significant spike in CPU-usage for routes that have multiple images (e.g. an image carousel).
How?
By calculating and storing the upstream etag in the cache entry, we can utilize the previously cached entry to check if the upstream image has remained the same, making it possible to reuse the previously cached entry again, as the image optimization would produce the same results anyways.