Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with-temporal example to utilize the app router. #73833

Open
wants to merge 12 commits into
base: canary
Choose a base branch
from

Conversation

PapatMayuri
Copy link
Contributor

This PR updates the with-next-sass example for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 12, 2024
@ijjk
Copy link
Member

ijjk commented Dec 12, 2024

Allow CI Workflow Run

  • approve CI run for commit: 20524e8

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

socket-security bot commented Dec 12, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@tsconfig/[email protected] None 0 2.36 kB typescript-deploys
npm/[email protected] None 0 220 kB remy
npm/[email protected] Transitive: environment, filesystem, shell +22 111 MB tempbearpig

🚮 Removed packages: npm/[email protected]

View full report↗︎

@PapatMayuri PapatMayuri marked this pull request as ready for review December 12, 2024 08:14
@samcx
Copy link
Member

samcx commented Dec 12, 2024

@PapatMayuri The endpoint /api/orders should be converted to a Route Handler if we're updating this to App Router.

@PapatMayuri
Copy link
Contributor Author

@samcx I have updated code please check.

@samcx samcx self-requested a review December 17, 2024 01:26
@samcx
Copy link
Member

samcx commented Dec 17, 2024

@PapatMayuri Can you verify this example is working via a video of the app running?

@PapatMayuri
Copy link
Contributor Author

@samcx If we click on create order the api is failing we are getting 500(Internal Server Error) this error was getting before changes also.

@samcx
Copy link
Member

samcx commented Dec 17, 2024

@PapatMayuri Can you share the error?

@PapatMayuri
Copy link
Contributor Author

PapatMayuri commented Dec 18, 2024

@samcx attaching screenshot of error which we are getting, clicking on create order
Screenshot 2024-12-18 at 10 32 44

@samcx
Copy link
Member

samcx commented Dec 18, 2024

@PapatMayuri Let's refactor the Layout component into the Root Layout file.

@PapatMayuri
Copy link
Contributor Author

@samcx I have Refactored the Layout component into the Root Layout file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants