Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Use provided waitUntil for pending revalidates (#74164) #74573

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 7, 2025

This backports #74164 to leverage built-in waitUntil if available instead of using the approach that keeps the stream open until the waitUntil promise resolves.

x-ref: slack thread

@ijjk ijjk requested review from ztanner and huozhi January 7, 2025 01:04
@ijjk
Copy link
Member Author

ijjk commented Jan 7, 2025

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
buildDuration 15.4s 13.9s N/A
buildDurationCached 8.6s 6.7s N/A
nodeModulesSize 201 MB 201 MB ⚠️ +62.9 kB
nextStartRea..uration (ms) 406ms 410ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB
5428.HASH.js gzip 181 B 180 B N/A
6067-HASH.js gzip 5.14 kB 5.14 kB
6428-HASH.js gzip 31.6 kB 31.6 kB N/A
framework-HASH.js gzip 44.9 kB 44.9 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.3 kB 32.3 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 104 kB 104 kB
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 185 B N/A
amp-HASH.js gzip 502 B 504 B N/A
css-HASH.js gzip 321 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 258 B 257 B N/A
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 371 B 372 B N/A
image-HASH.js gzip 4.32 kB 4.32 kB N/A
index-HASH.js gzip 259 B 257 B N/A
link-HASH.js gzip 2.67 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 314 B N/A
script-HASH.js gzip 385 B 386 B N/A
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 654 B 654 B
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
_buildManifest.js gzip 484 B 481 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
edge-ssr.js gzip 95.5 kB 95.6 kB ⚠️ +114 B
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 95.5 kB 95.6 kB ⚠️ +114 B
Middleware size
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
middleware-b..fest.js gzip 659 B 656 B N/A
middleware-r..fest.js gzip 156 B 154 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 839 B 839 B
Next Runtimes Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
app-page-exp...dev.js gzip 172 kB 172 kB ⚠️ +104 B
app-page-exp..prod.js gzip 98.3 kB 98.4 kB ⚠️ +101 B
app-page-tur..prod.js gzip 100 kB 100 kB N/A
app-page-tur..prod.js gzip 94.3 kB 94.4 kB N/A
app-page.run...dev.js gzip 146 kB 146 kB N/A
app-page.run..prod.js gzip 92.8 kB 92.9 kB N/A
app-route-ex...dev.js gzip 22.5 kB 22.6 kB N/A
app-route-ex..prod.js gzip 15.9 kB 16 kB N/A
app-route-tu..prod.js gzip 15.9 kB 16 kB N/A
app-route-tu..prod.js gzip 15.6 kB 15.7 kB N/A
app-route.ru...dev.js gzip 22.1 kB 22.2 kB N/A
app-route.ru..prod.js gzip 15.6 kB 15.7 kB N/A
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.2 kB 23.2 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.6 kB 51.8 kB ⚠️ +109 B
Overall change 419 kB 419 kB ⚠️ +314 B
build cache
vercel/next.js 14-2-1 vercel/next.js ijjk/backport-built-in-wait-until Change
0.pack gzip 1.63 MB 1.63 MB N/A
index.pack gzip 115 kB 114 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: ca90a6d

@ijjk ijjk requested a review from lubakravche January 7, 2025 01:38
@ijjk ijjk merged commit d60bb1b into 14-2-1 Jan 7, 2025
51 of 56 checks passed
@ijjk ijjk deleted the ijjk/backport-built-in-wait-until branch January 7, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants