fix(next): allow typegen without active bundler#94954
Open
mturac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allows
next typegento load config without requiring an active bundler when bundler-specific experimental options are present.Why?
next typegendoes not run webpack or Turbopack, but it currently loads config through the production build phase. That makesexperimental.turbopackRustReactCompilerfail unlessTURBOPACKis set, even though type generation itself does not need a bundler.How?
loadConfigcall fromnext typegenas typegen-only while preserving the publicPHASE_PRODUCTION_BUILDvalue passed tonext.config.js.next typegen; normal build/dev validation still runs.Fixes #94950
Tests
pnpm jest packages/next/src/server/config.test.ts --runInBandpnpm test-dev test/e2e/app-dir/typegen-turbopack-rust-react-compiler/typegen-turbopack-rust-react-compiler.test.tspnpm test-dev test/e2e/app-dir/typegen-error-diagnostic/typegen-error-diagnostic.test.tspnpm --filter=next build