Fix array query params in client-side navigation#94956
Open
AshokGaire3 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaced
Object.fromEntries(new URLSearchParams(renderedSearch))withurlSearchParamsToParsedUrlQuerywhen computing segment cache keys in the client-side router.Why?
When submitting a form with multiple checkboxes that share the same
nameattribute, the URL reflects arrays in query parameters (e.g.,?type=test1&type=test2). During a client navigation,Object.fromEntrieswas incorrectly omitting all but the last parameter (resulting in{"type":"test2"}), causing the client router segment matching to falsely hit the local cache and show stale UI state.How?
Using the
urlSearchParamsToParsedUrlQueryutility correctly parses identical duplicate search parameter keys into arrays, which constructs a correct segment key, leading to a successful dynamic route prefetch on change.Verification
next starttest.GETrequest to/?type=test2&_rsc=...is correctly spawned upon navigating away from/?type=test1&type=test2.