[vercel/otel] update install step #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dvoytenko
requested changes
Nov 12, 2024
| @@ -9,7 +9,7 @@ | |||
| ## 📦 Installation | |||
|
|
|||
| ```sh | |||
| npm install @vercel/otel | |||
| npm install @vercel/otel @opentelemetry/api @opentelemetry/api-logs @opentelemetry/instrumentation @opentelemetry/resources @opentelemetry/sdk-logs @opentelemetry/sdk | |||
There was a problem hiding this comment.
Why are these needed? IIUC:
@opentelemetry/apiand@opentelemetry/api-logsget in as peer deps@opentelemetry/instrumentationand@opentelemetry/sdk/sdk-logsshouldn't be needed at all.@opentelemetry/resources- I don't think this one is needed either
There was a problem hiding this comment.
@dvoytenko The dependencies I added here are listed as peerDependencies listed in the package.json
When using pnpm to install @vercel/otel, they are missing from node_modules (check the screenshot below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@verce/otelhas a couple of peer dependencies which needs to be installed and were missing in the docs.