-
Notifications
You must be signed in to change notification settings - Fork 1.3k
upgrade repo's deps and replace deprecated apis #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
5631545 to
d1bc6a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project's dependencies and updates deprecated APIs to maintain compatibility with newer versions. The changes modernize the testing infrastructure and build configuration while ensuring code quality.
- Upgrade CI Node.js version to 22 and pnpm to version 10.17.0
- Replace deprecated Jest matchers with their modern equivalents
- Migrate from legacy ESLint configuration format to the new flat config format
Reviewed Changes
Copilot reviewed 46 out of 49 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates dependency versions including Jest, ESLint, TypeScript and other dev dependencies |
| eslint.config.mjs | New flat ESLint configuration replacing the legacy .eslintrc format |
| .eslintrc | Removed legacy ESLint configuration file |
| test/*.tsx | Updates Jest assertions from deprecated matchers to modern equivalents (toBeCalled → toHaveBeenCalled) |
| src/**/*.ts | Removes unnecessary ESLint disable comments and updates import paths |
| .github/workflows/*.yml | Updates CI configuration to use Node.js 22 and newer Playwright version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks for the PR, is it possible to separate this huge PR into few smaller ones? Like each PR can only contribute to one purpose such as upgrade node version, or change the ci. This PR's goal seems pretty general and it might be difficult to track or revert in the future. Thanks! |
|
Thanks for reviewing this large pr ❤️. The changes of this pr are interrelated so i did not create small PRs to update them individually. I understant you concerns about this PR. It touches too many files. But most of changes are just adding or removing comments. It won't be too hard to track or revert in the future. In future maintenance, we can use Copilot to periodically help us update the repository’s development dependencies, making subsequent upgrades smoother. But for now i guess we need to pay the previous tech debt. |
Uh oh!
There was an error while loading. Please reload this page.