fix: reconcile configuration input (#41)

vercel · Nov 4, 2024 · a22bc8b · a22bc8b
1 parent 23a4fff
commit a22bc8b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/vercel-deployment-task-source/src/index.ts b/vercel-deployment-task-source/src/index.ts
@@ -105,23 +105,23 @@ function reconcileConfigurationInput(
     );
   }
 
-  if (!envVarValue) {
-    if (!inputValue) {
-      if (!defaultValue) {
-        throw new Error(
-          `${name} must be specified using input \`${inputKey}\` or environment variable \`${envVarKey}\``
-        );
-      }
-
-      setVariable(envVarKey, defaultValue);
-      return defaultValue;
-    }
-
+  if (inputValue) {
     setVariable(envVarKey, inputValue);
     return inputValue;
   }
 
-  return envVarValue;
+  if (envVarValue) {
+    return envVarValue;
+  }
+
+  if (defaultValue) {
+    setVariable(envVarKey, defaultValue);
+    return defaultValue;
+  }
+
+  throw new Error(
+    `${name} must be specified using input \`${inputKey}\` or environment variable \`${envVarKey}\``
+  );
 }
 
 async function run() {

diff --git a/vercel-deployment-task-source/task.json b/vercel-deployment-task-source/task.json
@@ -11,7 +11,7 @@
   "version": {
     "Major": 1,
     "Minor": 6,
-    "Patch": 3
+    "Patch": 4
   },
   "instanceNameFormat": "Deploying $(vercelProject) to Vercel",
   "inputs": [

diff --git a/vss-extension.json b/vss-extension.json
@@ -3,7 +3,7 @@
   "manifestVersion": 1,
   "id": "vercel-deployment-extension",
   "name": "Vercel Deployment Extension",
-  "version": "1.6.3",
+  "version": "1.6.4",
   "publisher": "Vercel",
   "public": true,
   "targets": [