This repository has been archived by the owner on Oct 21, 2023. It is now read-only.
mod : ClanGroup Size Penalty moved to server configuration #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verdie-g
suggested changes
Jul 28, 2023
Moved it to server configuration. So we can change it for a single day on a server by server basis , and run analysis of rounds for each server to tweak the penalty on a per server basis. |
namidaka
changed the title
verdie-g
suggested changes
Aug 1, 2023
| || !float.TryParse(sizePenaltyStr, out float sizePenalty) | ||
| || sizePenalty > 1.5f) | ||
| { | ||
| Debug.Print($"Invalid server multiplier: {sizePenaltyStr}"); |
| @@ -25,11 +25,28 @@ public static void Init() | |||
| public static CrpgRegion Region { get; } | |||
| public static string Service { get; } | |||
| public static string Instance { get; } | |||
| public static float ClanGroupSizePenalty { get; private set; } = 0f; | |||
There was a problem hiding this comment.
Since it's a global variable it's important to give as much context as possible in the name. We often say
The length of the identifier should be proportional to the distance between its declaration and use.
So here you could go with TeamBalancerClanGroupSizePenalty and crpg_team_balancer_clan_group_size_penalty
namidaka
force-pushed
the
remove-rating-penalty
branch
from
e2fd767
to
4783cec
Compare
verdie-g
approved these changes
Aug 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.