This repository has been archived by the owner on Oct 21, 2023. It is now read-only.
mod: add Dtv viscount attacked message #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verdie-g
suggested changes
Aug 1, 2023
| [DefineGameNetworkMessageTypeForMod(GameNetworkMessageSendType.FromServer)] | ||
| internal sealed class CrpgDtvViscountUnderAttackMessage : GameNetworkMessage | ||
| { | ||
| public Agent Attacker { get; set; } = default!; |
There was a problem hiding this comment.
I think it's better to keep the property nullable because
I think ReadAgentReferenceFromPacket could return null if the agent doesn't exist. It's very unlikely that this will ever happen but we never know.
There was a problem hiding this comment.
I've changed the property to nullable, let me know if you are happy with it and I will request some translations for the message to send in the event that the agent doesn't exist.
src/Module.Server/ModuleData/Languages/CNs/std_module_strings_xml-zho-CN.xml
Outdated
Show resolved
Hide resolved
verdie-g
suggested changes
Aug 1, 2023
Comment on lines
90
to
93
| else | ||
| { | ||
| textObject = new("{=}The Viscount is under attack!"); | ||
| } |
There was a problem hiding this comment.
It's fine to just ignore that case.
verdie-g
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notifies players when viscount is under attack