Add custom item holster positions #1221
Conversation
This will allow us to have custom holster positions for items in the future: Example already included in the files: https://i.imgur.com/9CYMCqV.png
| <?xml version="1.0" encoding="utf-8"?> | ||
| <base> | ||
| <item_holsters> | ||
| <item_holster id="katana_left_hip" equip_action="act_equip_sword" equip_action_left_stance="act_equip_sword_left_stance" unequip_action="act_unequip_sword" unequip_action_left_stance="act_unequip_sword_left_stance" show_holster_when_drawn="false" group_name="hip_left_sword_3" holster_skeleton="holster_skeleton_hip_left" base_set="abdomen_front" holster_position="0.120, 0.070, 0.220" holster_rotation_yaw_pitch_roll="-56.180, 70.790, -120.0"/> |
There was a problem hiding this comment.
How is the link made between the katana item and that holster position?
There was a problem hiding this comment.
Good catch.
Holsters are defined in the crafting_templates.xml for crafted items and in the weapons.xml or shields.xml for single piece items that do not use the crafting system.
I would add the new category in there when I change the items on the item repo.
If you like it better I can add the empty one with this PR though.
There was a problem hiding this comment.
Yes let's just add the empty file
There was a problem hiding this comment.
Done, since we we will be using the katana parts those are already in there as well.
Added <CraftingTemplate id="Katana" <CraftingTemplate id="Wakizashi" for 1h and 2h
| @@ -9260,4 +9260,73 @@ | |||
| <UsablePiece piece_id="crpg_meowhammer_handle_h3" /> | |||
| </UsablePieces> | |||
| </CraftingTemplate> | |||
| <CraftingTemplate id="Wakizashi" item_type="OneHandedWeapon" modifier_group="sword" item_holsters="katana_left_hip:katana_left_hip_2:katana_left_hip_3" piece_type_to_scale_holster_with="Blade" hidden_piece_types_on_holster="Blade" default_item_holster_position_offset="0,0,-0.1"> | |||
There was a problem hiding this comment.
How come this template was not existing before? Also the modifications done here might be overwritten by the next time @namidaka synchronizes the 2 repositories.
There was a problem hiding this comment.
Indeed this must be done in item balancing , and not here
There was a problem hiding this comment.
They did not exist before because we did not have the custom holster positions we wanted to apply to some weapons.
Now that we want make use of them, those custom templates need to be added so weapons can use them.
Both need to happen on the other repo since the exporter will crash if the custom item_holsters.xml is not available but weapons are using the new crafting template that references those holster positions.
My suggestion would be only adding the custom item_holsters.xml here, syncing it to the item balancing repo and then adding crafting templates and the weapons that use them on there.
That way we have no situation on any repo that could cause issues.
Reverted the crafting_templates.xml changes.
This reverts commit 7cebcd8.
This will allow us to have custom holster positions for items in the future.
Example already included in the files:
https://i.imgur.com/9CYMCqV.png