Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing AE reviewer feedback for FormaliSE25 submission #253

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

sammsaski
Copy link
Contributor

As mentioned in title. There were lots of changes:

  • Adding datasets to Zenodo and including DOI in the README to improve self-containment of artifact.
  • Adding npy-matlab package to artifact via git submodules to improve self-containment of artifact.
  • Improving the installation instructions by being more thorough and limiting the need for users to bounce between installation instructions for the various dependencies (all instructions contained in README now.)
  • Ensuring that the figs/ directory exists on download/clone of artifact.
  • Adding more description about what the artifact contains and its purpose, as well as clarifying the need to submit the entire NNV tool as the artifact.
  • Making clearer the MATLAB toolboxes and other dependencies that are needed.
  • Resolving typos and other minor issues (MATLAB version, typos in commands, etc.).

@ttj ttj merged commit 06049bd into verivital:master Jan 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants