Skip to content

[recipe, doc] feat: add MiniMax H3 FlowGRPO V1 sync recipes - #501

Draft
NancyFyong wants to merge 3 commits into
verl-project:mainfrom
NancyFyong:recipe/minimax-h3-flowgrpo-v1-sync
Draft

[recipe, doc] feat: add MiniMax H3 FlowGRPO V1 sync recipes#501
NancyFyong wants to merge 3 commits into
verl-project:mainfrom
NancyFyong:recipe/minimax-h3-flowgrpo-v1-sync

Conversation

@NancyFyong

@NancyFyong NancyFyong commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add production MiniMax H3 FlowGRPO V1 sync launch recipes for both
supported GPU paths:

  • run_minimax_h3_t2va_lora_v1.sh; and
  • run_minimax_h3_fl2va_lora_v1.sh.

They are mechanical counterparts of the existing V0 recipes. Each preserves
all model, LoRA, reward, pipeline, and CPS FlowGRPO settings, and changes only:

main_diffusion -> main_diffusion_v1
trainer.use_v1=true
trainer.v1.trainer_mode=sync
experiment name *_v1_gpu

The MiniMax H3 README documents both launchers and explains that V1 sync uses
TransferQueue and ReplayBuffer. separate_async is intentionally out of scope:
it needs dedicated actor/rollout resource pools plus checkpoint-engine
synchronization, so it is not a mechanical entrypoint switch.

Why this is not duplicate work

The relevant V1 tracking issue is #389. Duplicate-work checks found V1 work for
Qwen-Image (#489) and OPD (#493 and #495), but no open PR or launcher for
MiniMax H3 FlowGRPO V1, T2VA, or FL2VA. In particular, no existing branch adds
run_minimax_h3_t2va_lora_v1.sh or run_minimax_h3_fl2va_lora_v1.sh.

This PR adds recipes only. It does not modify MiniMax H3 adapters, FlowGRPO
losses, the V1 trainer, or GPU smoke registration.

Tests

Passed:

bash -n examples/flowgrpo_trainer/minimax_h3/run_minimax_h3_t2va_lora_v1.sh
bash -n examples/flowgrpo_trainer/minimax_h3/run_minimax_h3_fl2va_lora_v1.sh

# Both scripts with --cfg job and representative environment overrides
# resolved trainer.use_v1=true and trainer.v1.trainer_mode=sync.

python -c 'import transfer_queue'
pre-commit run --files \
  examples/flowgrpo_trainer/minimax_h3/README.md \
  examples/flowgrpo_trainer/minimax_h3/run_minimax_h3_t2va_lora_v1.sh \
  examples/flowgrpo_trainer/minimax_h3/run_minimax_h3_fl2va_lora_v1.sh
git diff --check

A mechanical comparison also confirmed that each V1 launcher retains every V0
runtime setting after normalizing the approved entrypoint, V1 flags, and
experiment-name changes.

No GPU training run was performed: this PR is intentionally limited to
production recipes and does not add a GPU smoke. The existing TinyRandom
T2VA+FL2VA FlowGRPO E2E coverage is tracked separately in #447.

Reward Results

image

AI assistance and review

AI assistance (pi coding agent) was used for this change. The human submitter
has reviewed every changed line and is responsible for this contribution.

Provide T2VA and FL2VA V1 sync launchers so MiniMax H3 can use
TransferQueue and ReplayBuffer without changing its established FlowGRPO
model, reward, pipeline, or CPS SDE settings.

AI assistance (pi coding agent) was used for this change.

Co-authored-by: pi coding agent
Signed-off-by: NancyFyong <2742092809@qq.com>
@NancyFyong
NancyFyong requested a review from SamitHuang as a code owner August 31, 2026 11:51
Copilot AI lite review requested due to automatic review settings August 31, 2026 11:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@knlnguyen1802 knlnguyen1802 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all v1 recipes, we need to verify the reward curve again

@NancyFyong
NancyFyong marked this pull request as draft August 31, 2026 13:04
@NancyFyong

Copy link
Copy Markdown
Collaborator Author

For all v1 recipes, we need to verify the reward curve again

I will switch to "open" after the reward phase. Thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants