[cfg] feat: support NPU profiling - #507
Draft
SelfDLer wants to merge 1 commit into
Draft
Conversation
Expose the upstream NPU profiler configuration so Ascend runs can select NPU profiling without local config overrides. AI assistance (OpenAI Codex) was used to reorganize this change. Co-authored-by: OpenAI Codex <noreply@openai.com> Signed-off-by: leovzhang <coffeeofzl@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add NPU profiler configuration for Ascend training.
The shared profiler config now exposes
NPUToolConfig, allowing diffusion and Omni trainers to selectnpuprofiling and configure collection contents, level, analysis mode, database layout, and response-token profiling bounds. The generated trainer reference configs are updated to include the same fields.Checklist Before Starting
[{modules}] {type}: {description}.Test
scripts/generate_trainer_config.sh- passed (All good).git diff --check upstream/main...HEAD- passed.PR_TITLE='[cfg] feat: support NPU profiling' python tests/special_sanity/check_pr_title.py- passed.pre-commit run --all-files --show-diff-on-failure --color=always- not fully runnable in this Windows checkout: upstream symlinks are materialized as link-target text and two repository hooks require POSIXsh. No failures came from this PR's YAML diff.API and Usage Example
Role-level options are available under
actor_rollout_ref.<role>.profiler.tool_config.npu.Design & Code Changes
nputo the supported profiler tool choices.Checklist Before Submitting
AI assistance (OpenAI Codex) was used to prepare this Draft PR and run checks.