Skip to content

[recipe, doc] chore: default Wan2.2 DanceGRPO docs to v1 and deprecate v0 - #509

Open
knlnguyen1802 wants to merge 1 commit into
verl-project:mainfrom
knlnguyen1802:doc/wan22-dancegrpo-v1-default
Open

[recipe, doc] chore: default Wan2.2 DanceGRPO docs to v1 and deprecate v0#509
knlnguyen1802 wants to merge 1 commit into
verl-project:mainfrom
knlnguyen1802:doc/wan22-dancegrpo-v1-default

Conversation

@knlnguyen1802

Copy link
Copy Markdown
Collaborator

After #466, CUDA DanceGRPO should start from the V1 sync recipe. Point every user-facing doc at run_wan22_5b_t2v_hpsv3_v1.sh and mark the v0 auto-detect launcher deprecated for CUDA (NPU still uses it).

What does this PR do?

Add concise overview of what this PR aims to achieve or accomplish. Reference related GitHub issues and PRs that help with the review.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, vllm_omni, rollout, trainer, ci, training_utils, recipe, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward, diffusion, omni, tests, docker
    • If this PR involves multiple modules, separate them with , like [diffusion, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][diffusion, fsdp] feat: new rollout scheduler

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

  • Read the Contribute Guide.
  • Apply pre-commit checks: pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always
  • Add / Update the documentation.
  • Add unit or end-to-end test(s) to the CI workflow to cover all the code. If not feasible, explain why: ...

…e v0

After verl-project#466, CUDA DanceGRPO should start from the V1 sync recipe.
Point every user-facing doc at run_wan22_5b_t2v_hpsv3_v1.sh and mark
the v0 auto-detect launcher deprecated for CUDA (NPU still uses it).

AI assistance (Cursor) was used for this change.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: knlnguyen1802 <knlnguyen1802@gmail.com>
Comment thread README.md

## News 🔥

- **[2026-09]** [Wan2.2 DanceGRPO](examples/dancegrpo_trainer/README.md) now defaults to the V1 sync trainer (TransferQueue). The v0 auto-detect launcher is deprecated for CUDA.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too trivial. Let annouce it once all models switch to v1 trainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants