[recipe, doc] chore: default Wan2.2 DanceGRPO docs to v1 and deprecate v0 - #509
Open
knlnguyen1802 wants to merge 1 commit into
Open
[recipe, doc] chore: default Wan2.2 DanceGRPO docs to v1 and deprecate v0#509knlnguyen1802 wants to merge 1 commit into
knlnguyen1802 wants to merge 1 commit into
Conversation
…e v0 After verl-project#466, CUDA DanceGRPO should start from the V1 sync recipe. Point every user-facing doc at run_wan22_5b_t2v_hpsv3_v1.sh and mark the v0 auto-detect launcher deprecated for CUDA (NPU still uses it). AI assistance (Cursor) was used for this change. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: knlnguyen1802 <knlnguyen1802@gmail.com>
Open
4 tasks
SamitHuang
reviewed
Sep 3, 2026
|
|
||
| ## News 🔥 | ||
|
|
||
| - **[2026-09]** [Wan2.2 DanceGRPO](examples/dancegrpo_trainer/README.md) now defaults to the V1 sync trainer (TransferQueue). The v0 auto-detect launcher is deprecated for CUDA. |
Collaborator
There was a problem hiding this comment.
It's too trivial. Let annouce it once all models switch to v1 trainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #466, CUDA DanceGRPO should start from the V1 sync recipe. Point every user-facing doc at run_wan22_5b_t2v_hpsv3_v1.sh and mark the v0 auto-detect launcher deprecated for CUDA (NPU still uses it).
What does this PR do?
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,vllm_omni,rollout,trainer,ci,training_utils,recipe,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,diffusion,omni,tests,docker,like[diffusion, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][diffusion, fsdp] feat: new rollout schedulerTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always