Skip to content

[tool] feat: add profile skill - #580

Draft
NancyFyong wants to merge 1 commit into
verl-project:mainfrom
NancyFyong:skill-profile
Draft

[tool] feat: add profile skill#580
NancyFyong wants to merge 1 commit into
verl-project:mainfrom
NancyFyong:skill-profile

Conversation

@NancyFyong

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds a new agent skill profile under .agents/skills/profile/SKILL.md.

It is a router (same style as add-pipeline / run-cpu-tests / self-review):
it points at the authoritative docs/perf/profiler.md and fills only the
cross-cutting decisions that guide leaves implicit — which tool answers which
question (nsys / torch.profiler / torch_memory / MFU / RL-Insight), why to
profile one lightweight step instead of a full run, which process owns each phase
(actor / rollout server / reward-model server / ref), the key=value vs
+key=value override rule, the main_diffusion_v1 nsys caveat, and not
hand-rolling profilers in adapter code. No code, config, or docs pages change.

Checklist Before Starting

Test

No code paths change, so there are no unit tests. Verified locally:

  • All 12 pre-commit hooks pass on the changed file (pre-commit run --files .agents/skills/profile/SKILL.md), including Generate and verify _generated_*.yaml (no config touched), Check docs Last updated info, and
    Check licenseSKILL.md is correctly excluded from both, like the
    existing skills.
  • PR-title validator passes: PR_TITLE="[tool] feat: add profile skill" python tests/special_sanity/check_pr_title.py → valid, modules ['tool'], type
    feat.
  • All three docs the skill routes to exist: docs/perf/profiler.md,
    docs/perf/diffusion_mfu.md, docs/start/rl_insight.md.

API and Usage Example

Discovered by the agent harness the same way as the other skills (one
SKILL.md per directory with name + description front matter). It triggers
when a performance/profiling question comes up, e.g.:

> profile the actor update of the SD3.5 OCR run and tell me where the time goes
# -> loads .agents/skills/profile/SKILL.md, which routes to docs/perf/profiler.md
#    recipe 1 (torch) or 4a (nsys), pins a one-step lightweight footprint, and
#    enables actor_rollout_ref.actor.profiler.

Design & Code Changes

  • New file: .agents/skills/profile/SKILL.md (front matter + a concise routing
    body). Nothing else changes.
  • Deliberately a router, not a copy: docs/perf/profiler.md stays the single
    source of truth for the config surface and the six recipes; the skill only
    adds tool-selection and the recurring traps.

Checklist Before Submitting

  • Read the AGENTS.md.
  • Follows the [{modules}] {type}: {description} title format.
  • Pre-commit hooks pass.
  • Human line-by-line review of the changed file.

AI assistance was used for this change.

Route a performance investigation to the right tool (nsys / torch.profiler /
torch_memory / MFU / RL-Insight) and profile one lightweight step. Mirrors the
router style of the existing skills and points at docs/perf/profiler.md as the
authoritative config surface, filling the cross-cutting decisions it leaves
implicit (which process owns each phase, plain vs + overrides, the V1 nsys
caveat, and not hand-rolling profilers in adapter code).

AI assistance (pi coding agent) was used for this change.

Co-authored-by: pi coding agent
Signed-off-by: NancyFyong <2742092809@qq.com>
Copilot AI lite review requested due to automatic review settings September 10, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants