Skip to content

[rollout] fix: use the same request_ids in each rollout turn for better tracking in rollout backend #5271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterSH6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[rollout] fix: use the same request_ids in each rollout turn for better tracking in rollout backend #5271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion verl/experimental/agent_loop/agent_loop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ async def generate(
"""
server = self._choose_server(request_id)
output = await server.generate.remote(
request_id=uuid4().hex, # use new request_id for each turn
request_id=request_id, # use the same request_id for better tracking
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Using the same request_id across multiple turns could lead to issues if the backend relies on unique request_ids for identifying individual requests. This might cause incorrect caching or interference between turns. It's important to ensure that the backend system can handle the same request_id for related turns within a trajectory without any conflicts or errors.

Consider adding a mechanism to ensure uniqueness across different trajectories, perhaps by incorporating a trajectory ID or session ID into the request_id.

Suggested change
request_id=request_id, # use the same request_id for better tracking
request_id=f"{request_id}_turn", # use the same request_id for better tracking

Copy link
Collaborator

@wuxibin89 wuxibin89 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We better to use new request_id for each turn

prompt_ids=prompt_ids,
sampling_params=sampling_params,
image_data=image_data,
Expand Down