Update installation instruction to the actual repo link#5290
Update installation instruction to the actual repo link#5290Godofnothing wants to merge 4 commits intoverl-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix the repository path in the installation instructions by updating the git clone URL. The changes made are correct, but the fix is incomplete as several other references to the old repository URL still exist throughout the documentation and Dockerfiles. I've left a comment detailing the other locations that require updating to ensure all links point to the correct repository.
|
|
||
| # install the nightly version (recommended) | ||
| git clone https://github.com/volcengine/verl && cd verl | ||
| git clone https://github.com/verl-project/verl && cd verl |
There was a problem hiding this comment.
While this change correctly updates the repository URL, the fix is incomplete. There are several other occurrences of the old URL https://github.com/volcengine/verl that still need to be updated to https://github.com/verl-project/verl to ensure consistency and prevent confusion.
Please update the URL in the following locations as well:
In docs/start/install.rst:
- Line 57
- Line 58
- Line 64
- Line 65
- Line 107
- Line 211
- Line 239
In docker/Dockerfile.stable.vllm:
- Line 102
In docker/Dockerfile.stable.sglang:
- Line 39
A global search-and-replace for volcengine/verl with verl-project/verl across the repository would be the best approach to ensure all references are updated.
|
|
2 participants
This PR fixes the repo path in installation instruction and docker files.