Skip to content

[tool] fix: make rate-limiter actor detached to prevent ActorDiedError #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirrorboat wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

[tool] fix: make rate-limiter actor detached to prevent ActorDiedError #5327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions verl/tools/search_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,20 @@ def __init__(self, enable_global_rate_limit=True, rate_limit=10):
self.rate_limit_worker = self._init_rate_limit(rate_limit) if enable_global_rate_limit else None

def _init_rate_limit(self, rate_limit):
"""Initialize singleton rate limiter."""
return TokenBucketWorker.options(name="rate-limiter", get_if_exists=True).remote(rate_limit)
"""Initialize singleton rate limiter as a detached actor."""
namespace = ray.get_runtime_context().namespace
try:
actor = ray.get_actor("rate-limiter", namespace=namespace)
logger.info("Reusing existing detached rate-limiter actor.")
return actor
except ValueError:
logger.info("Creating new detached rate-limiter actor.")
return TokenBucketWorker.options(
name="rate-limiter",
lifetime="detached",
namespace=namespace,
get_if_exists=True
).remote(rate_limit)
Comment on lines +82 to +94
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The use of the generic name "rate-limiter" for a detached actor is risky because it can collide with other tools (such as SandboxFusionTool in this repository) that might also use the same name within the same Ray namespace. If another tool creates a non-detached actor with this name first, this code will reuse it, and the ActorDiedError will still occur when that other tool is destroyed. Additionally, the try...except block and manual namespace handling are redundant; Ray's get_if_exists=True option in options() already handles the 'get or create' logic safely and respects the current namespace by default.

        # Use a specific name to avoid collisions with other tools in the same namespace.
        return TokenBucketWorker.options(
            name="search-tool-rate-limiter",
            lifetime="detached",
            get_if_exists=True
        ).remote(rate_limit)


def ping(self):
"""Health check method."""
Expand Down