Skip to content

[algo] feat: add Focal-GRPO implementation#5334

Open
alekseymalakhov11 wants to merge 2 commits intoverl-project:mainfrom
alekseymalakhov11:add-f-grpo
Open

[algo] feat: add Focal-GRPO implementation#5334
alekseymalakhov11 wants to merge 2 commits intoverl-project:mainfrom
alekseymalakhov11:add-f-grpo

Conversation

@alekseymalakhov11
Copy link

@alekseymalakhov11 alekseymalakhov11 commented Feb 16, 2026

What does this PR do?

This PR adds the official implementation of F-GRPO. It introduces focal weighting into GRPO/DAPO/CISPO-style loss functions, improving pass@k performance while maintaining comparable pass@1 results.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a well-structured implementation of the F-GRPO algorithm. The changes are consistent across configuration files and the core algorithm logic. The new compute_f_grpo_outcome_advantage function is cleanly implemented, leveraging existing utilities for efficiency and includes robust parameter validation. I've identified a minor but important documentation issue regarding the paper reference, which I've commented on.

@alekseymalakhov11
Copy link
Author

This also resolves #5256
fyi @Felix-Zhenghao

@alekseymalakhov11
Copy link
Author

It looks like the other failing tests are unrelated to this PR and are also failing on the main branch.

I’d appreciate it if someone could take a look and review my PR
@PeterSH6 @tongyx361 @vermouth1992 @eric-haibin-lin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant