Fixes for byte compiler & update travis #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabranham
force-pushed
the
fixes-for-byte-compiler
branch
from
324bcb3
to
1a7608c
Compare
|
Rebased onto master @vermiculus |
|
Sorry I've been absent; I'll take a look at this by tomorrow night. |
|
No problem, and no rush! |
jabranham
force-pushed
the
fixes-for-byte-compiler
branch
from
1a7608c
to
875b9b5
Compare
|
Rebased, and fixed a few more things the byte compiler was complaining about |
|
Pushed a commit to make travis error on compiler warnings |
jabranham
changed the title
|
Turns out I lied Do you mind if I keep this open anyway? |
|
Yes, sorry I didn't mean to close. Was looking at old lingering PRs and must've hit the wrong button. |
|
Is this something that's still valuable to merge after all this time? Happy to do so if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes so the byte compiler is satisfied, a few checkdoc fixes.
string-as-unibyteis obsolete in upcoming Emacs 26, Can you double-check that(encode-coding-string data 'no-conversion)is right?