migrated user-mail-server to v12 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils-vertel
reviewed
Apr 13, 2022
user_mail_server/i18n/sv.po
Outdated
| #: model:ir.actions.act_window,name:user_mail.action_user_mail_sync | ||
| #: view:user.mail.sync.wizard:user_mail.user_mail_sync_view | ||
| msgid "Synchronize Settings" | ||
| msgstr "Synkroniserade inställningar" |
There was a problem hiding this comment.
I believe that the correct translation should be
"Synkronisera Inställningar"
nils-vertel
reviewed
Apr 13, 2022
| ctx.update({'no_reset_password': True}) | ||
| return super(ResUsers, self.with_context(ctx)).create(values) | ||
|
|
||
| def write(self, values): |
There was a problem hiding this comment.
Do we need to use @api.multi here and a for loop or can it be like this here? (same apply for unlink)
There was a problem hiding this comment.
@api.multi can be added but no need for loop
nils-vertel
reviewed
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.