Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-7128: view.mergeAllowed/wipeAllowed to pull required perms from index data #3750

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

MichaelSquires
Copy link
Contributor

@MichaelSquires MichaelSquires commented Jun 11, 2024

feat: Update layer permissions checking with the user object for optimized checking.
bugfix: Update synapse.lib.coro.pause() default value for number of iterations from 1000 to 10.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.62%. Comparing base (6f18bfd) to head (d9886d0).

Files Patch % Lines
synapse/lib/storm.py 71.42% 2 Missing ⚠️
synapse/cortex.py 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3750      +/-   ##
==========================================
- Coverage   97.74%   97.62%   -0.12%     
==========================================
  Files         237      237              
  Lines       51202    51226      +24     
==========================================
- Hits        50045    50008      -37     
- Misses       1157     1218      +61     
Flag Coverage Δ
linux 97.62% <97.72%> (-0.02%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelSquires MichaelSquires marked this pull request as ready for review June 11, 2024 19:26
synapse/lib/layer.py Outdated Show resolved Hide resolved
@MichaelSquires MichaelSquires merged commit da323b9 into master Jun 14, 2024
5 checks passed
@MichaelSquires MichaelSquires deleted the blackout/SYN-7128/layer-perms-part2 branch June 14, 2024 17:48
@vEpiphyte vEpiphyte added enhancement reqChangelog requires changelog labels Jun 21, 2024
@vEpiphyte vEpiphyte added this to the v2.172.0 milestone Jun 21, 2024
@vEpiphyte vEpiphyte removed the reqChangelog requires changelog label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants