Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent some IndexErrors (SYN-8488 SYN-8523) #4068

Merged
merged 14 commits into from
Jan 15, 2025

Conversation

rakuy0
Copy link
Contributor

@rakuy0 rakuy0 commented Jan 14, 2025

No description provided.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (e52efdb) to head (2a26905).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4068      +/-   ##
==========================================
+ Coverage   96.19%   96.41%   +0.22%     
==========================================
  Files         256      256              
  Lines       59739    59753      +14     
==========================================
+ Hits        57464    57611     +147     
+ Misses       2275     2142     -133     
Flag Coverage Δ
linux 96.41% <100.00%> (+11.64%) ⬆️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vEpiphyte vEpiphyte added this to the v2.194.0 milestone Jan 14, 2025
invisig0th
invisig0th previously approved these changes Jan 14, 2025
MichaelSquires
MichaelSquires previously approved these changes Jan 14, 2025
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we want to warnonce in the try case? Seems like that message could get spammy.

@vEpiphyte vEpiphyte added the bug label Jan 14, 2025
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still leaving Python AttributeError exceptions leaking into the runtime.

@rakuy0 rakuy0 dismissed stale reviews from MichaelSquires and invisig0th via beba449 January 14, 2025 21:52
@rakuy0 rakuy0 changed the title Prevent some IndexErrors (SYN-8488) Prevent some IndexErrors (SYN-8488 SYN-8523) Jan 14, 2025
@vEpiphyte vEpiphyte merged commit 827f1ad into master Jan 15, 2025
3 checks passed
@vEpiphyte vEpiphyte deleted the rakuyo/guidctor-indexerr-8488 branch January 15, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants