-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent some IndexErrors (SYN-8488 SYN-8523) #4068
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4068 +/- ##
==========================================
+ Coverage 96.19% 96.41% +0.22%
==========================================
Files 256 256
Lines 59739 59753 +14
==========================================
+ Hits 57464 57611 +147
+ Misses 2275 2142 -133
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do we want to warnonce in the try case? Seems like that message could get spammy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still leaving Python AttributeError
exceptions leaking into the runtime.
…ect/synapse into rakuyo/guidctor-indexerr-8488
beba449
Co-authored-by: blackout <[email protected]>
…ect/synapse into rakuyo/guidctor-indexerr-8488
No description provided.