$lib.cache.fixed - convert StormCtrlFlow exceptions to StormRuntimeError (SYN-8513)#4073
Merged
$lib.cache.fixed - convert StormCtrlFlow exceptions to StormRuntimeError (SYN-8513)#4073
Conversation
vEpiphyte
requested review from
Cisphyx,
MichaelSquires,
OCBender and
mikemoritz
MichaelSquires
requested changes
Jan 15, 2025
Co-authored-by: blackout <blackout@vertex.link>
MichaelSquires
previously approved these changes
Jan 15, 2025
OCBender
previously approved these changes
Jan 15, 2025
vEpiphyte
dismissed stale reviews from MichaelSquires and OCBender
via
b78808c
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4073 +/- ##
==========================================
- Coverage 96.47% 96.40% -0.08%
==========================================
Files 256 256
Lines 59753 59757 +4
==========================================
- Hits 57648 57610 -38
- Misses 2105 2147 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cisphyx
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously these returned
Nonebut that hides possible errors.