Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a restore point info in the vdb status #942

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

roypaulin
Copy link
Collaborator

@roypaulin roypaulin commented Oct 1, 2024

This fetches a restore point info through the show_restore_points api, and saves it to the status so that the user can easily find it.

Copy link
Collaborator

@cchen-vertica cchen-vertica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating the vrep, could we collect the restore point's id and index and store it in vdb or somewhere? Then we remove the vrep so the user doesn't know we did a vrep creation.

Or we just call vclusterOps API to get the restore point's info rather than creating a vrep CR.

// a restore point. When this is false, after saving a restore point, the operator
// will create a VerticaRestorePointsQuery in order to expose the restore point info
// the user.
SkipVRPQCreationAnnotation = "vertica.com/skip-restore-points-query-creation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this annotation? We should always create the VRep CR to collect the restore point's info for the user.

@roypaulin
Copy link
Collaborator Author

After creating the vrep, could we collect the restore point's id and index and store it in vdb or somewhere? Then we remove the vrep so the user doesn't know we did a vrep creation.

Or we just call vclusterOps API to get the restore point's info rather than creating a vrep CR.

A few reasons why I did it this way:

  • I don't want show_restore_points failure to fail the whole save_restore_point.
  • I don't want to slow down save_restore_point while there is a separate controller dedicated to show_restore_points.*
  • Duplicate information. There is already a CR that can contain the info we want, and we will be duplicating that info over to the VDB CR.
  • A user can create multiple restore_points which mean we would need to add an array to the vdb status to contain the info about all of them

@roypaulin roypaulin changed the title Create a vrpq after saving a restore point Show a restore point info in the vdb status Oct 3, 2024
@roypaulin
Copy link
Collaborator Author

I went a slightly different direction. I added a reconciler for show_restore_point. It will detect if show_restore_point is needed from the status and will update the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants