fix(multisig): gate add_admin/remove_admin/update_required_signatures through execute_action - #216
Open
BWM0223 wants to merge 1 commit into
Open
fix(multisig): gate add_admin/remove_admin/update_required_signatures through execute_action#216BWM0223 wants to merge 1 commit into
BWM0223 wants to merge 1 commit into
Conversation
…rough execute_action
Contributor
Author
|
This PR closes the auth bypass where add_admin, remove_admin, and update_required_signatures were exposed as public entrypoints with no auth checks, allowing any address to alter the admin set or reduce the signature threshold. The fix ensures these operations only execute through the multi-sig execute_action flow which requires the configured number of distinct admin approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #68 - Public add_admin/remove_admin/update_required_signatures bypass multi-sig entirely
Root Cause
Three public entrypoints perform no auth check. Any address can remove admins or reduce signature threshold to 1. add_admin self-authorizes the new admin.
Fix