Add optional kubeconfig path to roles #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see potential here for the future if we need access to remote clusters. For example for multi region "infrastructure" deployment. |
austintalbot
force-pushed
the
feature/add-optional-kubeconfig-path
branch
from
cf06f20
to
723adc5
Compare
fix vexxhost#1838 # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Author: Oleksandr K <[email protected]> # Date: Wed Sep 4 21:04:03 2024 +0200 # # On branch feature/add-optional-kubeconfig-path # Your branch is behind 'origin/feature/add-optional-kubeconfig-path' by 1 commit, and can be fast-forwarded. # (use "git pull" to update your local branch) # # Changes to be committed: # modified: .gitignore # modified: roles/barbican/defaults/main.yml # modified: roles/barbican/tasks/main.yml # modified: roles/ceph_csi_rbd/defaults/main.yml # modified: roles/ceph_csi_rbd/tasks/main.yml # modified: roles/ceph_provisioners/defaults/main.yml # modified: roles/ceph_provisioners/tasks/main.yml # modified: roles/cinder/defaults/main.yml # modified: roles/cinder/tasks/main.yml # modified: roles/cluster_issuer/defaults/main.yml # modified: roles/coredns/defaults/main.yml # modified: roles/coredns/tasks/main.yml # modified: roles/designate/defaults/main.yml # modified: roles/designate/tasks/main.yml # modified: roles/glance/defaults/main.yml # modified: roles/glance/tasks/main.yml # modified: roles/goldpinger/defaults/main.yml # modified: roles/goldpinger/tasks/main.yml # modified: roles/heat/defaults/main.yml # modified: roles/heat/tasks/main.yml # modified: roles/horizon/defaults/main.yml # modified: roles/horizon/tasks/main.yml # modified: roles/ingress_nginx/defaults/main.yml # modified: roles/ingress_nginx/tasks/main.yml # modified: roles/ironic/defaults/main.yml # modified: roles/ironic/tasks/main.yml # modified: roles/keycloak/defaults/main.yml # modified: roles/keycloak/tasks/main.yml # modified: roles/keystone/defaults/main.yml # modified: roles/keystone/tasks/main.yml # modified: roles/kube_prometheus_stack/defaults/main.yml # modified: roles/kube_prometheus_stack/tasks/main.yml # modified: roles/libvirt/defaults/main.yml # modified: roles/libvirt/tasks/main.yml # modified: roles/local_path_provisioner/defaults/main.yml # modified: roles/local_path_provisioner/tasks/main.yml # modified: roles/loki/defaults/main.yml # modified: roles/loki/tasks/main.yml # modified: roles/magnum/defaults/main.yml # modified: roles/magnum/tasks/main.yml # modified: roles/manila/defaults/main.yml # modified: roles/manila/tasks/main.yml # modified: roles/memcached/defaults/main.yml # modified: roles/memcached/tasks/main.yml # modified: roles/neutron/defaults/main.yml # modified: roles/neutron/tasks/main.yml # modified: roles/node_feature_discovery/defaults/main.yml # modified: roles/node_feature_discovery/tasks/main.yml # modified: roles/nova/defaults/main.yml # modified: roles/nova/tasks/main.yml # modified: roles/octavia/defaults/main.yml # modified: roles/octavia/tasks/main.yml # modified: roles/openvswitch/defaults/main.yml # modified: roles/openvswitch/tasks/main.yml # modified: roles/ovn/defaults/main.yml # modified: roles/ovn/tasks/main.yml # modified: roles/percona_xtradb_cluster/vars/main.yml # modified: roles/percona_xtradb_cluster_operator/defaults/main.yml # modified: roles/percona_xtradb_cluster_operator/tasks/main.yml # modified: roles/placement/defaults/main.yml # modified: roles/placement/tasks/main.yml # new file: roles/powerstore_csi/defaults/main.yaml # modified: roles/powerstore_csi/tasks/main.yml # modified: roles/prometheus_pushgateway/defaults/main.yml # modified: roles/prometheus_pushgateway/tasks/main.yml # modified: roles/rabbitmq_cluster_operator/defaults/main.yml # modified: roles/rabbitmq_cluster_operator/tasks/main.yml # modified: roles/rook_ceph/defaults/main.yml # modified: roles/rook_ceph/tasks/main.yml # modified: roles/rook_ceph_cluster/defaults/main.yml # modified: roles/rook_ceph_cluster/tasks/main.yml # modified: roles/staffeln/defaults/main.yaml # modified: roles/staffeln/tasks/main.yaml # modified: roles/tempest/defaults/main.yml # modified: roles/tempest/tasks/main.yml # modified: roles/vector/defaults/main.yml # modified: roles/vector/tasks/main.yml # # Untracked files: # build/release.sh # doc/source/admin/ceph.rst # roles/cluster_issuer/tasks/type/acme/solver/azuredns.yml #
austintalbot
force-pushed
the
feature/add-optional-kubeconfig-path
branch
from
723adc5
to
10ae738
Compare
|
recheck |
|
@austintalbot sorry, I was out of the office because of a personal emergency, in order to avoid a bunch of back and forth, I've made a small amendment in order to be able to fit better the existing variable naming convention. Once this will pass CI, I will go ahead and merge it. |
|
recheck |
|
/cherry-pick stable/2024.1 |
|
@mnaser: once the present PR merges, I will cherry-pick it on top of stable/2024.1 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mnaser
approved these changes
Sep 25, 2024
|
@mnaser: new pull request created: #1919 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
atmosphere-ci bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
This is an automated cherry-pick of #1871 /assign mnaser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.