Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATMOSPHERE-589] Add support for nfs_shares_config #2121

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ATMOSPHERE-589] Add support for nfs_shares_config #2121

wants to merge 5 commits into from
+78 −0

Conversation

larainema
Copy link
Member

No description provided.

@larainema
Add support for nfs_shares_config
f88cf4b
@larainema
update the configmap
0228528 
update the configmap to include the contents of nfs_shares_config
mnaser
mnaser requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing missing, we actually need to replace the value of nfs_shares_config in the final generated config file to become /etc/cinder/nfs/{{ $key }} so that it points to that mount, cause right now it's actually just going to the data still.

charts/cinder/templates/deployment-volume.yaml Outdated Show resolved Hide resolved
charts/cinder/templates/configmap-etc.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaser mnaser mnaser requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larainema @mnaser