Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.28.x support #403

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Kubernetes 1.28.x support #403

merged 7 commits into from
Jun 28, 2024

Conversation

0x00ace
Copy link
Contributor

@0x00ace 0x00ace commented Jun 28, 2024

@mnaser
You can safely merge this - it will add only support for k8s 1.28.x
With k8s 1.28.x there is no issues with keystone auth

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

@0x00ace I'm picking this branch up from your side to wrap up real quick )

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

@0x00ace ok, made some changes that will even work with v1.28 now and add testing, I made rockylinux non voting because it is failing often.

@0x00ace since you contributed rocky support, do you use it both with 8 and 9? I want to try and fix up capo-image-elements to build rockylinux images for you but want to know where to spend my time, so we can have reliable rocky tests :)

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

Looks like Cilium is broken with those images, working on testing it here and will push fix shortly.

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

I'm working on making Rocky voting again @0x00ace to not make a waste of your effort:

vexxhost/capo-image-elements#4

I will merge this for now however, thank you for your efforts.

@mnaser mnaser merged commit 3a24c9f into vexxhost:main Jun 28, 2024
12 checks passed
@0x00ace
Copy link
Contributor Author

0x00ace commented Jun 28, 2024

@mnaser
I'm using Rocky 9.
Also, I have made cilium to work, and have no problem with cilium patches from the main branch. I had just added cilium helm chart to the vendor dir and removed it from gitignore.

@mnaser
Copy link
Member

mnaser commented Jun 28, 2024

Can you see the PR in capo image elements and see if you can help with that if you don't mind?

We're hoping to move to building with that. It's so much faster and more reliable.

@0x00ace
Copy link
Contributor Author

0x00ace commented Jun 28, 2024

Can you see the PR in capo image elements and see if you can help with that if you don't mind?

We're hoping to move to building with that. It's so much faster and more reliable.

Yes, I understand that we are trying to migrate to a new way of image creation. I need some time to deep dive on how it's working and will try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants