Updated customer metadata to only store one old btCustomerId (bitward…

…en#4997) * Updated customer metadata to only store one old btCustomerId * Updated to include case where old key already exists * Updated SubscriberService to also save btCustomerId_old on the Stripe Customer's metadata --------- Co-authored-by: Matt Bishop <[email protected]>
vgrassia · Nov 21, 2024 · e2a0b9e · e2a0b9e
1 parent 05e078e
commit e2a0b9e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/Core/Billing/Services/Implementations/SubscriberService.cs b/src/Core/Billing/Services/Implementations/SubscriberService.cs
@@ -523,8 +523,9 @@ await stripeAdapter.PaymentMethodAttachAsync(token,
 
                     var metadata = customer.Metadata;
 
-                    if (metadata.ContainsKey(BraintreeCustomerIdKey))
+                    if (metadata.TryGetValue(BraintreeCustomerIdKey, out var value))
                     {
+                        metadata[BraintreeCustomerIdOldKey] = value;
                         metadata[BraintreeCustomerIdKey] = null;
                     }
 

diff --git a/src/Core/Billing/Utilities.cs b/src/Core/Billing/Utilities.cs
@@ -7,6 +7,7 @@ namespace Bit.Core.Billing;
 public static class Utilities
 {
     public const string BraintreeCustomerIdKey = "btCustomerId";
+    public const string BraintreeCustomerIdOldKey = "btCustomerId_old";
 
     public static async Task<SubscriptionSuspension> GetSubscriptionSuspensionAsync(
         IStripeAdapter stripeAdapter,

diff --git a/src/Core/Services/Implementations/StripePaymentService.cs b/src/Core/Services/Implementations/StripePaymentService.cs
@@ -1360,9 +1360,9 @@ public async Task<bool> UpdatePaymentMethodAsync(ISubscriber subscriber, Payment
         {
             if (braintreeCustomer?.Id != stripeCustomerMetadata["btCustomerId"])
             {
-                var nowSec = Utilities.CoreHelpers.ToEpocSeconds(DateTime.UtcNow);
-                stripeCustomerMetadata.Add($"btCustomerId_{nowSec}", stripeCustomerMetadata["btCustomerId"]);
+                stripeCustomerMetadata["btCustomerId_old"] = stripeCustomerMetadata["btCustomerId"];
             }
+
             stripeCustomerMetadata["btCustomerId"] = braintreeCustomer?.Id;
         }
         else if (!string.IsNullOrWhiteSpace(braintreeCustomer?.Id))