Skip to content

Commit

Permalink
Merge pull request #3423 from vgteam/upgrade-toil
Browse files Browse the repository at this point in the history
Upgrade Toil used for CI
  • Loading branch information
adamnovak authored Sep 20, 2021
2 parents 0e44c19 + 9404a72 commit 22044be
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
5 changes: 4 additions & 1 deletion vgci/vgci.py
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,10 @@ def _mapeval_vg_run(self, reads, base_xg_path, sim_xg_paths,
sim_chunks += 1
opts += '--maxCores {} --sim_chunks {} --seed {} '.format(self.cores, sim_chunks, 8)
if sim_opts:
opts += '--sim_opts \'{}\' '.format(sim_opts)
# Make sure to prefix the sim options string with a space so that
# Toil's parser doesn't see a leading dash and decide it's an
# option and not an argument.
opts += '--sim_opts \' {}\' '.format(sim_opts)
if sim_fastq:
opts += '--fastq {} '.format(sim_fastq)
opts += '--annotate_xg {} '.format(base_xg_path)
Expand Down
20 changes: 9 additions & 11 deletions vgci/vgci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ SHOW_OPT=""
TOIL_VG_PACKAGE="git+https://github.com/vgteam/toil-vg.git@b79e340073832324e9714ca1f52e5cfb6cd3990d"
# What toil should we install?
# Could be something like "toil[aws,mesos]==3.20.0"
# or "git+https://github.com/adamnovak/toil.git@2b696bec34fa1381afdcf187456571d2b41f3842#egg=toil[aws,mesos]"
TOIL_PACKAGE="toil[aws,mesos]==3.24.0"
# or "git+https://github.com/DataBiosphere/toil.git@3ab74776a3adebd6db75de16985ce9d734f60743#egg=toil[aws,mesos]"
TOIL_PACKAGE="git+https://github.com/DataBiosphere/toil.git@3ab74776a3adebd6db75de16985ce9d734f60743#egg=toil[aws,mesos]"
# What tests should we run?
# Should be something like "vgci/vgci.py::VGCITest::test_sim_brca2_snp1kg_mpmap"
# Must have the Python file in it or Pytest can't find the tests.
Expand Down Expand Up @@ -338,15 +338,13 @@ then
export TMPDIR
fi

# Dependencies for running tests. Need numpy, scipy and sklearn
# for running toil-vg mapeval, and dateutils and reqests for ./mins_since_last_build.py
pip3 install numpy==1.17.1
pip3 install scipy==1.0.0rc2 --only-binary :all:
pip3 install scikit-learn==0.22.1
pip3 install dateutils
pip3 install requests
pip3 install timeout_decorator
pip3 install pytest
# Dependencies for running tests. Need numpy, scipy and sklearn for
# running toil-vg mapeval, and dateutils and reqests for
# ./mins_since_last_build.py. Make sure to get the giant buildable modules
# as binaries only to avoid wasting CI time building some slightly nicer
# version Pip prefers.
pip3 install pytest timeout_decorator requests dateutils
pip3 install numpy scipy scikit-learn --only-binary :all:

# Install Toil
echo "Installing toil from ${TOIL_PACKAGE}"
Expand Down

1 comment on commit 22044be

@adamnovak
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for merge to master. View the full report here.

16 tests passed, 0 tests failed and 0 tests skipped in 10813 seconds

Please sign in to comment.