Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump goutils #36

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Bump goutils #36

merged 1 commit into from
Oct 2, 2024

Conversation

benjirewis
Copy link
Member

No description provided.

@benjirewis benjirewis marked this pull request as ready for review October 1, 2024 16:59
Copy link
Member

@Otterverse Otterverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjirewis
Copy link
Member Author

Need to test this doesn't break current "get" functionality on the agent. I also may want to increase some network timeouts in this PR if there are any in the agent since network operations behind the bluetooth SOCKS proxy are especially slow. Do you foresee any issue with that @Otterverse ?

@Otterverse
Copy link
Member

Need to test this doesn't break current "get" functionality on the agent. I also may want to increase some network timeouts in this PR if there are any in the agent since network operations behind the bluetooth SOCKS proxy are especially slow. Do you foresee any issue with that @Otterverse ?

Yes, potentially. The main one is obviously the download time. I don't remember if there's a "timeout" specifically, but... a really long download can be a really long block at startup, since on a fresh start, updates are downloaded/installed before each subsystem is started. So I expect some work may need to be done to background downloads and not block the normal healthcheck/startup loop. I'm not really sure what that looks like.

That said, bumping goutils alone isn't likely to make current behavior WORSE, so still good to merge on this specific PR... or it can become a bigger one if you want. Just note that I'm changing a lot of this very soon, so may not want to put in the effort on that yet.

@benjirewis
Copy link
Member Author

benjirewis commented Oct 2, 2024

That said, bumping goutils alone isn't likely to make current behavior WORSE, so still good to merge on this specific PR... or it can become a bigger one if you want. Just note that I'm changing a lot of this very soon, so may not want to put in the effort on that yet.

Sounds good; I won't change any timeouts here and will just bump goutils. I tested locally and the agent still seems to work as expected.

@benjirewis benjirewis merged commit 35667e2 into viamrobotics:main Oct 2, 2024
1 check passed
@benjirewis benjirewis deleted the bump-goutils branch October 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants