[spark-compete wave 1] install & build right - #304
Merged
Conversation
registry.py DEFAULT_LAB_PATH hardcoded ~/Desktop/spark-personality-chip-labs/personalities, which breaks installs that don't have the lab checked out on the Desktop. Switch the default to the platform-safe ~/.spark/spark-personality-chip-labs/personalities location, consistent with the search paths already prioritized in chip_loader.DEFAULT_CHIP_LAB_PATHS. Narrowed from PR #28: the chip_loader.py hunk was dropped because HEAD already prioritizes ~/.spark/modules/... and ~/.spark/... ahead of Desktop and uses the stronger guard 'spark-personality-chip-labs' in path.parts (a better impl than the PR's 'in str(path)'). Only the still-unfixed registry.py one-line default is landed here. Co-authored-by: johncrossu <johncrossu@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark Compete — Wave 1 ("install & build right")
Maintainer-consolidated Wave-1 PRs for this repo, from the Spark Compete audit.
Commits
On-merge points (not written until merge)
johncrossu 7
Verification
python3 -m compileall -q src/spark_character/registry.py is clean. chip_loader.py left untouched (PR hunk dropped per maintainer note; HEAD already has the superior impl). git diff is exactly the single intended registry.py line change. No stray compete-*.json packet files at repo root. Full test/CI
Fraud/duplicate-split PRs excluded per ruleset v2. Draft — nothing merges or scores until reviewed.
🤖 Generated with Claude Code