[spark-compete wave 4] memory / persona / voice (stacked) by vibeforge1111 · Pull Request #306 · vibeforge1111/spark-character

vibeforge1111 · 2026-06-25T14:50:44Z

Spark Compete — Wave 4 (memory / persona / voice), stacked on `spark-compete/wave1-install-build`

Wave-4 delta only. Maintainer-consolidated memory/personality/voice PRs.

Commits

fix(security): detect .env exfiltration in prompt-guard secret pattern [[spark-compete] fix(security): fix broken secret-exfiltration pattern in prompt guard to detect .env exfiltration #291]
fix(codex): guard call_codex against missing binary/timeout and redact stderr [[spark-compete] fix(codex): preserve operator next-move when codex binary is missing #295, [spark-compete] [severity:2] fix(character): codex exec RuntimeError contains raw stderr #296]
fix(memory): open SIB state.db read-only and redact sib_home from error [[spark-compete] enhance(src): src/spark_character/memory_grounded #276, [spark-compete] [severity:2] fix(character): FileNotFoundError exposes sib_home path #297]
fix(security): redact internal filesystem paths from not-found errors (Esc1200 287+286 = one redaction band; TALLSOME24 298) [[spark-compete] fix: remove path leaks from critic and registry error messages #287, fix: remove internal path details from FileNotFoundError messages #286, [spark-compete] [severity:2] fix(character): FileNotFoundError exposes full artifact path #298]
fix(evals): structured logging instead of traceback.print_exc in continuous_eval [[spark-compete] fix: replace traceback.print_exc() with structured logging in continuous_eval #285]
enhance(evals): make a tied-at-ceiling tier still qualify as weakest [[spark-compete] enhance(evals): evals/lowest_tier_watch #267]
fix(evals): name ARTIFACTS_DIR + seed remediation when no persona.vN.md found [fix(evals): name the ARTIFACTS_DIR path + seed remediation when persona.vN.md is missing #299]
fix(reliability): guard full_pulse T1 scorer + validate CODEX_PATH binary (git-URL @master pins reverted) [[spark-compete] fix(reliability): wrap score_persona in try/except in full_pulse to prevent daemon crash #290]
fix(chip-loader): actionable schema errors + searched-lab basenames in not-found [[spark-compete] [severity:low] fix(chip-loader): make chip schema validation errors actionable (UPSTREAM-spark-character-6) #6]
fix(memory): scrub Windows Desktop path + real user id from docstring example (broken chip_loader conflict hunk discarded) [[spark-compete] fix: replace hardcoded Windows Desktop path and real user ID in memory_grounded docstring #21]
fix(evals): exit 0 on baseline-holds in compare_personas (POSIX convention) [[spark-compete] fix: exit-0 on candidate-did-not-win in evals/compare_personas.py to match POSIX exit-code convention #66]
fix(registry): keep base-chip basename in invalid-YAML error (debuggability follow-up to 287) [[spark-compete] fix: remove path leaks from critic and registry error messages #287]

On-merge points (not written until merge)

4gjnbzb4zf-sudo 125 · ifeoluwaaj 52 · Esc1200 42 · TALLSOME24 38 · johncrossu 5

Verified: proportionate diff, no CRLF churn, no conflict markers. Compiles / tests green. Draft — gated on CI + approval.

🤖 Generated with Claude Code

The secret-exfiltration guard used \b before the alternation, but \b does not match between a non-word char (.) and a word char in '.env', so 'curl ... .env' slipped past. Replace the leading \b with a (?<!\w) look-behind so the dot-prefixed token matches. PR #291 Co-authored-by: ifeoluwaaj@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…t stderr PR #295 (adopt): wrap subprocess.run in try/except so a missing codex binary (FileNotFoundError) or an exceeded budget (TimeoutExpired) surface as an actionable RuntimeError that preserves the operator's next move, instead of a raw stack trace. PR #296 (adjust): redact the raw stderr from the non-zero-exit RuntimeError (keep rc for triage, drop the stderr payload that can carry internal paths or prompt fragments). Per maintainer note, the tautological packet test (re-implemented the message, never imported codex_provider) was discarded; replaced with tests/test_codex_exec_stderr.py exercising the real call_codex redaction path via a monkeypatched subprocess.run. PR #295 PR #296 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-authored-by: TALLSOME24@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

PR #276 (adopt): open state.db via 'file:...?mode=ro' URI so the probe builder can never accidentally mutate SIB's authoritative state (the user_instructions / personality_observations tables). PR #297 (adjust): redact sib_home from the _open_state FileNotFoundError ('State database not found'). Per maintainer note, the tautological packet test (re-implemented the message, never imported memory_grounded) was discarded; replaced with tests/test_memory_grounded_path.py exercising the real _open_state on a directory with no state.db. PR #276 PR #297 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-authored-by: TALLSOME24@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Consolidated path-redaction across the character runtime's FileNotFoundError / ValueError messages so callers no longer learn the internal directory layout. PR #287 (Esc1200, adopt): drop the full path from critic.load_critic and the base-chip YAML filename from registry.promote_evolved_persona_to_chip_lab. PR #286 (Esc1200, adjust; same-author same-concern as #287 -> one band): drop the search-path list from chip_loader.load_chip_by_id and replace the absolute artifact paths in persona.set_latest_persona_version / load_persona with the bare filename. Per maintainer note, also redact persona.load_persona_from_path (line 203) to the filename for consistency; the chip id / artifact filename are retained because they aid debugging. PR #298 (TALLSOME24, adjust): set_latest_persona_version line redaction. Per maintainer note the tautological packet test (re-implemented the message, never imported persona) was discarded; replaced with tests/test_persona_artifact_path.py exercising the real set_latest_persona_version against a missing artifact. The bundled packet-chip-loader-path-leak.json from #286 was excluded. PR #287 PR #286 PR #298 Co-authored-by: Esc1200@users.noreply.github.com Co-authored-by: TALLSOME24@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…inuous_eval Replace the two traceback.print_exc() calls in the continuous_eval loop with module-logger .exception() calls so failures land in structured logs (with the provider/context) rather than raw stderr dumps. PR #285 Co-authored-by: Esc1200@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

find_lowest_tier seeded weakest at (None, 1.0, 0), so when every eligible axis sits at the 1.0 ceiling the strict '< 1.0' comparison never fired and no tier was returned. Seed at (None, inf, 0) so a perfect-1.0 tier still qualifies as the weakest when all eligible axes tie at the ceiling. PR #267 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…md found When find_latest_persona has no persona.vN.md to load, the bare 'No persona.vN.md artifacts found.' gave the operator nowhere to look. Name the ARTIFACTS_DIR it searched and tell them to seed persona.v1.md there (or override ARTIFACTS_DIR), in both evolve.py and evolve_persona.py. PR #299 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@master

…nary PR #290 (adjust). Per maintainer note, landed ONLY the reliability/safety core: - full_pulse.py: wrap score_persona in try/except so a T1 scorer failure records an error row and continues instead of crashing the daemon. - codex_provider._default_codex_binary: when CODEX_PATH / SPARK_CODEX_PATH is set, expanduser + isfile-validate it (raise a clear FileNotFoundError) rather than blindly returning the string for execution. REVERTED (not applied): the two '@master' -> '@11c1d2da...' git-URL pins in evals/auto_loop.py and evals/lowest_tier_watch.py. Hardcoding this PR's own head commit into the self-evolution consumer-refresh loop would freeze auto-update and go stale on the next commit (a regression). Both URLs remain pinned to @master. PR #290 Co-authored-by: ifeoluwaaj@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…n not-found PR #6 (resurrect_adopt): make validate_chip_yaml_spec errors actionable - each type/shape failure now reports the offending type (got X) and a small inline YAML example, plus a pointer to the canonical chip schema doc. Also refines the #286 redaction of load_chip_by_id's FileNotFoundError: the full path-list was stripped, but the existing repo test (test_load_chip_by_id_omits_unavailable_desktop_lab_from_default_paths) asserts the *active* search-lab basenames stay in the message (while the unavailable Desktop lab must not). Restore the active-lab basenames (names only, de-duped/sorted) so the message stays debuggable without leaking the full filesystem layout. PR #6 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

… example PR #21 (resurrect_adjust). Per maintainer note the chip_loader.py hunk was a BROKEN DIFF (unresolved <<<<<<< / ======= / >>>>>>> conflict markers; HEAD already uses 'except recoverable_load_errors' which supersedes it) and was discarded. Landed ONLY the memory_grounded.py docstring fix: replace the embedded 'C:/Users/USER/Desktop/.../tmp-home' and the real 'human:telegram:8319079055' id in the usage example with 'Path.home() / ".spark" / "sib-home"' and a '<your-user-id>' placeholder. PR #21 Co-authored-by: johncrossu@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…ntion) PR #66 (resurrect_adjust). compare_personas.py returned 1 when the baseline held, conflating a domain verdict with a process failure. Flip to return 0 so a completed comparison always exits success; the verdict stays on stdout (WINS vs holds). Per maintainer note, confirmed no CI / Makefile / docs / wrapper in the repo branches on the old exit-1 signal, and documented the exit-0-always contract inline (option a). PR #66 Co-authored-by: 4gjnbzb4zf-sudo@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

…bility) Follow-up to the #287/#286 path-redaction: PR #287 over-redacted promote_evolved_persona_to_chip_lab's ValueError to fully generic, but the repo invariant (test_persona_sidecar_promotion_rejects_malformed_base_yaml) keeps the offending chip *basename* in the message. The basename is not a path leak (no surrounding directory) and aids debugging, matching the #286 maintainer guidance that the filename should be retained. Restore ': {base_yaml_path.name}'. PR #287 Co-authored-by: Esc1200@users.noreply.github.com Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vibeforge1111 · 2026-06-26T15:10:45Z

Superseded by r29: the full wave stack was squash-merged into the default branch via this repo's tip PR. Closing this intermediate wave-branch PR (branch retained; reopenable if needed).

Meta Alchemist and others added 12 commits June 25, 2026 18:32

vibeforge1111 closed this Jun 26, 2026

Navigation Menu

[spark-compete wave 4] memory / persona / voice (stacked) - #306

[spark-compete wave 4] memory / persona / voice (stacked)#306
vibeforge1111 wants to merge 12 commits into
spark-compete/wave1-install-buildfrom
spark-compete/wave4-memory-persona-voice

vibeforge1111 commented Jun 25, 2026

Uh oh!

vibeforge1111 commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

vibeforge1111 commented Jun 25, 2026

Spark Compete — Wave 4 (memory / persona / voice), stacked on spark-compete/wave1-install-build

Commits

On-merge points (not written until merge)

Uh oh!

vibeforge1111 commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Spark Compete — Wave 4 (memory / persona / voice), stacked on `spark-compete/wave1-install-build`