R30 Foundation adoption: spark-character - #328
Merged
Merged
Conversation
Agent-Id: alchemistab
Agent-Id: alchemistab
Agent-Id: alchemistab
Agent-Id: alchemistab
Agent-Id: alchemistab
Selectively adopt provider response bounding, safe transient recovery, and blank environment fallback from Spark Character PRs #102, #168, and #200. Preserve ambiguous POST failures as errors instead of replaying them. Source-PR: #102 @ 7e45453 Source-PR: #168 @ e41070d Source-PR: #200 @ 2c51b92 Co-authored-by: Esc1200 <esc1200@users.noreply.github.com> Co-authored-by: ifeoluwaaj <ifeoluwaaj@users.noreply.github.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Selectively adopt Spark Character PRs #151, #163, and #301. Resolve only owned Codex launcher names, bind explicit paths to the PATH-discovered launcher, reject empty output, and provide private actionable missing-output errors. Source-PR: #151 @ 83a8235 Source-PR: #163 @ b19fdcb Source-PR: #301 @ edc206c Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: Tallsome <tallsome24@gmail.com>
Adopt and selectively port Spark Character PRs #34, #150, #189, #196, and #239. Read JSONL newest-first without loading the file, preserve filtered-tail semantics, reject non-object rows, avoid duplicate pattern searches, and keep the usage example self-contained. Source-PR: #34 @ cab4fb6 Source-PR: #150 @ 18751dc Source-PR: #189 @ 9e27a9a Source-PR: #196 @ 8e0232e Source-PR: #239 @ 62748e1 Co-authored-by: driasim <driasim@users.noreply.github.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: Esc1200 <esc1200@users.noreply.github.com>
Adopt and selectively port Spark Character PRs #158, #201, and #235. Parse one JSON object with the real decoder, compile the fence pattern once, and write changed or intentionally cleared preference fields back to the chip schema. Source-PR: #158 @ 78285e5 Source-PR: #201 @ 5f90866 Source-PR: #235 @ 47ade44 Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: ifeoluwaaj <ifeoluwaaj@users.noreply.github.com>
Adopt and selectively port Spark Character PRs #127, #138, #145, and #159. Validate corpus and example shapes, skip invalid examples, and surface missing comparison evidence without calling the judge or fabricating a neutral score. Source-PR: #127 @ 1e749bd Source-PR: #138 @ 8d63da9 Source-PR: #145 @ c9d9ee3 (voice-judge portion only) Source-PR: #159 @ cca114f Co-authored-by: Esc1200 <esc1200@users.noreply.github.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: esc1200 <ekechisampson@gmail.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: ifeoluwaaj <ifeoluwaaj@users.noreply.github.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: esc1200 <ekechisampson@gmail.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: driasim <driasim@users.noreply.github.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: esc1200 <ekechisampson@gmail.com>
Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Retains timeout forwarding from #141, compile-once and malformed HTML cleanup from #157/#182, and prompt-safe result URLs from #207 while preserving R30 network authority. Co-authored-by: esc1200 <ekechisampson@gmail.com> Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: His Dudeness <banse@users.noreply.github.com>
Selectively ports Spark Character #130 with exclusive same-directory temp creation, fsync, atomic replacement, failure cleanup, and promotion-order coverage. Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Adopts Spark Character #229 with deterministic supported-provider guidance and explicit Codex availability feedback, covered without live providers. Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Adopts #225 so implicit persona and critic artifacts refresh per call while explicit inputs remain pinned. Retains #255's clearer critic conditional without treating its equivalent logic as a second behavioral fix. Co-authored-by: ifeoluwaaj <ifeoluwaaj@users.noreply.github.com> Co-authored-by: abh1shxkk <abhichauhan200504@gmail.com>
Adopts exact behavior from #161 and #166: compact JSON for downstream pipes and safe string coercion for structured reply previews, with no live observer data. Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com> Co-authored-by: driasim <driasim@users.noreply.github.com>
Selectively ports Spark Character #103 with per-tier error counts and privacy-safe exception-type diagnostics while preserving missing-score truth. Co-authored-by: esc1200 <ekechisampson@gmail.com>
Co-authored-by: NoRegretz <NoRegretz@users.noreply.github.com> Co-authored-by: NoRegretz <leventelorantffy@gmail.com>
Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
Co-authored-by: ValhallaBuilder <286693580+4gjnbzb4zf-sudo@users.noreply.github.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R30 Foundation adoption: spark-character
Review boundary
cbf3548a6a9b0e66cea5ebb1bd50666ef4390012masterat8cad27624c4bba34e52d5a1e67056d89d95c7cb2258(adopt=49, archive=44, selectively port=103, supersede=62)346665bb54481c82511d02b74c3d0f4b34e4da9a31406960d9e18db3b5d228e778Overlap and conflict resolution
194; retained families:135.0.Verification
318 passed,0 skipped,0 subtests passed.spark_character-0.24.0-py3-none-any.whl.081af50e41442f604635d38ad7971b82e1de4dc33a97371333a041873a11459b.Post-publication CI repair
cbf3548a6a9b0e66cea5ebb1bd50666ef4390012— test(r30): make Character CI hermetic.tests/test_codex_exec_stderr.py,tests/test_continuous_eval.py,tests/test_evolve_persona.py.Rollback and credit
24,409.0.Exact 34-commit manifest
554eb05a13a533855b0ad23a06311c4fcbe0b80d— alchemistab — fix(owner-input-adoption): harden persona persistence boundaries8220ff429e83820412468def928172c166fdf0bf— alchemistab — fix(owner-input-adoption): contain chip loading and rendering15ff7ea7908b233075fb63de812e73de096a337e— alchemistab — fix(owner-input-adoption): make character auto-loop truthful82f51759063cba46c61c824b363ccdf7cfbf71a8— alchemistab — fix(owner-input-adoption): make continuous eval evidence truthful13fca0c9b88becae8f4453442edbf933929778e9— alchemistab — fix(owner-input-adoption): fail closed on incomplete persona evidence46aba8f1e9566444f8c3ccba36e4ac6792dd55e7— alchemistab — fix(owner-input-adoption): make registry promotion atomicb737f49f369e18e4daa3fd09085011437df67279— alchemistab — fix(owner-input-adoption): report critic use truthfullycf46e2c04ce69cbd3a8a6d38199985149b739576— alchemistab — fix(owner-input-adoption): sanitize memory-grounded probese638de6f59f0062103df1c9dfb749053cd65685f— alchemistab — fix(owner-input-adoption): close invisible prompt smuggling42176680264283760fb444bb5b099a55f8814e8d— alchemistab — fix(owner-input-adoption): normalize short voice emphasisbe811290e4466f11631b9fe20c710661e411219b— alchemistab — fix(owner-input-adoption): harden provider boundariesf50e14f5a3cd951fad74957cc61c1ac7f2965a24— alchemistab — fix(owner-input-adoption): constrain codex execution99ee3d6c6a978bc53c960d921afa582581709cb7— alchemistab — fix(owner-input-adoption): bound audit log miningfac1f415412b62a5f58f89b6f63c9f2489757132— alchemistab — fix(owner-input-adoption): preserve trait evolution data0a7e7b2ead0ca1fb1e11b8b41f4bdcbfa360e7a6— alchemistab — fix(owner-input-adoption): require comparable voice corpora967f22e82d6f12608c055189988baff68191becb— alchemistab — fix(owner-input-adoption): make voice heuristics multilinguald33d5fc301cf83f28691e65612797ae6de54c682— alchemistab — fix(owner-input-adoption): reject missing judge scoresdc4623fa48e0c16b237869975f0c9e2685487bc2— alchemistab — fix(owner-input-adoption): fail closed on partial eval coverage804370883b20a25bd0c1521f2ef23e40f1f5df86— alchemistab — fix(owner-input-adoption): make score trends evidence exactad78afe820c485471cd6d9b210f491d1eaf7f9f0— alchemistab — fix(owner-input-adoption): make persona comparisons evidence complete49b1466a97c08fc12d3426e1930c75d84ed1ac35— alchemistab — fix(owner-input-adoption): recover observer state deterministically477759fe4d7b087ebd17ad8a461e932814e43cc5— alchemistab — fix(owner-input-adoption): harden lowest-tier watcher statebd08db54cdc1dd9af7f2ddd7216385b33e3230f1— alchemistab — fix(owner-input-adoption): harden live search contextccf5e8817c3bc0ce8143e080ff23ab4ce136c935— alchemistab — fix(owner-input-adoption): publish persona artifacts atomically84abad23a2e9b9a3699483d073dd8bbaa09a2fc5— alchemistab — fix(owner-input-adoption): surface unresolved provider names42526d498b9faf14a92d439348e1fbc08f07b50b— alchemistab — fix(owner-input-adoption): refresh implicit harness character69d3c8e292c292d092f169049312419b8bb18c9e— alchemistab — fix(owner-input-adoption): stabilize observation digest outputb9f3150138d07de1c641db26b022b2099fc78f04— alchemistab — fix(owner-input-adoption): preserve evolution failure evidence6be1f589dad9cd14a1d23af95a6bb9dace7ad482— alchemistab — fix(owner-input-adoption): sanitize loaded critic artifactsc1035105f88a4933769ebce738ca713960df5a50— alchemistab — fix(owner-input-adoption): expose scoring failure coverage7a7a3fef662730e878dbf6c28cf1e670ee145203— alchemistab — feat(owner-input-adoption): preserve command context boundaries6c9a5ab69587a5ca81ef2d72126de35472e24bc0— alchemistab — test(owner-input-adoption): pin synthetic chip context behavior5fa27845839a1c69f4bae721e722d1d2b9a303eb— alchemistab — fix(owner-input-adoption): align pulse guidance and live pathscbf3548a6a9b0e66cea5ebb1bd50666ef4390012— Meta Alchemist — test(r30): make Character CI hermeticThis PR changes only this repository's reviewed R30 owner lane. It does not include an installer repin, release ref, deployment, Telegram operation, or public point event.