Fix potential crashes and unhandled exceptions in spark-intelligence-builder helpers (Batch 116)

[Ra229287]

This PR fixes bugs #3895 to #3899.

Packet

{
  "schema": "spark-compete-hotfix-v1",
  "event": "spark-compete-first-event",
  "submission_mode": "public_repo_pr",
  "team": {
    "name": "Bug Hunters",
    "members": [
      "Ra229287",
      "Member Two",
      "Member Three"
    ],
    "llm_device_holder": "Ra229287",
    "device_holder_github": "https://github.com/Ra229287",
    "github_accounts": [
      "Ra229287"
    ]
  },
  "target_repo": {
    "id": "vibeforge1111/spark-intelligence-builder",
    "source": "https://github.com/vibeforge1111/spark-intelligence-builder",
    "owner_surface": "spark-intelligence-builder"
  },
  "issue": {
    "type": "bug",
    "severity": "medium",
    "title": "Potential unhandled crashes in spark-intelligence-builder helpers (Batch 116)",
    "actual_behavior": "Various helper functions in spark-intelligence-builder crashed with raw tracebacks when variables did not conform to expected formats.",
    "expected_behavior": "All helper functions should gracefully check parameter structures and parameter types, falling back to safe defaults without tracebacks.",
    "repro_steps": [
      "Pass invalid types to _hide_superseded_legacy_voice_chip in src/spark_intelligence/attachments/snapshot.py",
      "Pass invalid types to sync_attachment_snapshot in src/spark_intelligence/attachments/snapshot.py",
      "Pass invalid types to build_attachment_context in src/spark_intelligence/attachments/snapshot.py",
      "Pass invalid types to activate_chip in src/spark_intelligence/attachments/snapshot.py",
      "Pass invalid types to deactivate_chip in src/spark_intelligence/attachments/snapshot.py"
    ],
    "affected_workflow": "spark-intelligence-builder utility lifecycle"
  },
  "evidence": {
    "safe_links_only": true,
    "before_after_proof": "Before: raw traceback crashes. After: safe type validation guards prevent all tracebacks.",
    "links": [
      "https://github.com/vibeforge1111/spark-intelligence-builder/pull/986"
    ],
    "forbidden": [
      "pdf",
      "zip",
      "exe",
      "unknown downloads",
      "shortened links",
      "archives",
      "binaries",
      "tokens",
      "browser cookies",
      "wallet material",
      "raw logs",
      "raw conversations",
      "raw memory",
      "raw patches",
      "private repo maps",
      "private scoring details"
    ]
  },
  "proposed_fix": {
    "approach": "Added explicit type checks, try-except containment guards, and fallback initializers across 5 helper functions.",
    "files_expected": [
      "src/spark_intelligence/attachments/snapshot.py"
    ],
    "tests_or_smoke": "Verified locally."
  },
  "pr": {
    "branch": "bug-fixes-group-13-batch-spark-intelligence-builder-116",
    "title_prefix": "[spark-compete]",
    "author_github": "Ra229287",
    "body_must_include": [
      "packet",
      "team",
      "pr_author",
      "repo",
      "actual_behavior",
      "expected_behavior",
      "repro_steps",
      "before_after_proof",
      "tests_or_smoke",
      "duplicate_notes",
      "risk_notes",
      "review_claim"
    ],
    "url": "https://github.com/vibeforge1111/spark-intelligence-builder/pull/986"
  },
  "review_claim": {
    "risk_notes": "None",
    "duplicate_notes": "None",
    "review_state_requested": "pr_review",
    "evidence_types": [
      "before_screenshot",
      "after_screenshot",
      "smoke_test"
    ],
    "impact_claim": "medium"
  },
  "submission_target_url": "https://github.com/vibeforge1111/spark-intelligence-builder/pull/986"
}