[spark-compete] [severity:2] fix(chipLoop): err.stderr not redacted — raw subprocess output in error string - #819
Open
TALLSOME24 wants to merge 1 commit into
Conversation
… raw subprocess output in error string
NoRegretz
pushed a commit
to NoRegretz/spark-telegram-bot
that referenced
this pull request
Jul 1, 2026
…ure in error paths Cross-cutting information-disclosure hardening across the gateway, chip loop, and LLM CLI bridges. Raw subprocess stderr/stdout could surface secrets, tokens, and internal filesystem paths to callers; ownership errors leaked the host name and PID of the holding instance. - gatewayOwnership: ownership-conflict error no longer discloses hostname/PID, only an opaque ownerId (vibeforge1111#820) - chipLoop: run exec stderr passed through redactText() before inclusion in the returned error (vibeforge1111#819) - llm: Claude and Codex CLI failure errors run stderr/stdout through redactText() (vibeforge1111#818, vibeforge1111#817) - builderBridge: stderr in empty-stdout diagnostics errors is already redacted in HEAD; add a regression test to lock the behavior (vibeforge1111#816) Adds focused vitest regression tests for each surface. Co-authored-by: TALLSOME24 <TALLSOME24@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#819",
"team": {"name": "The Spark Plug", "members": ["TALLSOME24","Mrsankalove","Klausabdul"], "llm_device_holder": "TALLSOME24", "device_holder_github": "https://github.com/TALLSOME24", "github_accounts": ["TALLSOME24","Mrsankalove","Klausabdul"]},
"target_repo": {"id": "vibeforge1111/spark-telegram-bot", "source": "https://github.com/vibeforge1111/spark-telegram-bot", "owner_surface": "telegram-bot"},
"issue": {"type": "security_concern", "severity": "medium", "title": "chipLoop.ts appends raw err.stderr to error string at lines 74-75 — redactText() missing", "actual_behavior": "At src/chipLoop.ts lines 74-75, err.stderr.slice(-400) is appended bare to the error string. No redactText() call is made.", "expected_behavior": "err.stderr must be wrapped in redactText() before appending.", "repro_steps": ["Trigger the affected code path with sensitive content in stderr.", "Observe the error message contains raw output."], "affected_workflow": "runChipLoop() catch block in chipLoop.ts"},
"evidence": {"safe_links_only": true, "before_after_proof": "Before: err.stderr.slice(-400). After: redactText(err.stderr.slice(-400)).", "links": ["https://github.com//pull/819"], "forbidden": ["pdf","zip","exe","unknown downloads","shortened links","archives","binaries","tokens","browser cookies","wallet material","raw logs","raw conversations","raw memory","raw patches","private repo maps","private scoring details"]},
"proposed_fix": {"approach": "Applied redactText() wrapper to stderr value before inclusion in thrown error.", "files_expected": ["src/chipLoop.ts","tests/test_chip_loop_redact.test.ts"], "tests_or_smoke": "5 tests: raw stderr not in error, result not ok, sentinel present, fallback works, message preserved."},
"pr": {"branch": "fix/chip-loop-stderr-redact-main", "title_prefix": "[spark-compete]", "author_github": "TALLSOME24", "body_must_include": ["packet","team","pr_author","repo","actual_behavior","expected_behavior","repro_steps","before_after_proof","tests_or_smoke","duplicate_notes","risk_notes","review_claim"], "url": "https://github.com/vibeforge1111/spark-telegram-bot/pull/819"},
"review_claim": {"impact_claim": "medium", "evidence_types": ["failing_test","passing_test","smoke_test","redacted_conversation_excerpt"], "duplicate_notes": "No prior PR addressed chipLoop.ts stderr handling.", "risk_notes": "Only error string construction changes.", "review_state_requested": "pr_review"}
}