[spark-compete] Fix: add Repair guidance when chip-labs root not found in /chip create - #829
Open
Acone8 wants to merge 1 commit into
Conversation
NoRegretz
pushed a commit
to NoRegretz/spark-telegram-bot
that referenced
this pull request
Jul 1, 2026
… create vibeforge1111#829: preflight the resolved chipLabsRoot before launching the create mission; when the spark-domain-chip-labs module is missing, return a clear not-found error with a Repair block (install the module / check setup docs) instead of a downstream execFile failure. PRs: vibeforge1111#829 Co-authored-by: Acone8 <Acone8@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#829",
"team": {
"name": "Syntax Layer",
"members": ["Acone8", "Kruz45", "Dabstil"],
"llm_device_holder": "Acone8",
"device_holder_github": "https://github.com/Acone8",
"github_accounts": ["Acone8", "Kruz45", "Dabstil"]
},
"target_repo": {
"id": "vibeforge1111/spark-telegram-bot",
"source": "https://github.com/vibeforge1111/spark-telegram-bot",
"owner_surface": "telegram-bot"
},
"issue": {
"type": "bug",
"severity": "medium",
"title": "/chip create fails with chip-labs root not found but gives no install guidance",
"actual_behavior": "Sending /chip create a simple note taking app returns Chip create failed: chip-labs root not found: /Users/cyprian/.spark/domain-chip-labs with no guidance on how to fix it.",
"expected_behavior": "When the chip-labs root is missing, the error should tell the user that spark-domain-chip-labs is required and point them to agent.sparkswarm.ai for setup instructions.",
"repro_steps": ["Send /chip create a simple note taking app in Telegram.", "Observe: Chip create failed: chip-labs root not found with no repair guidance.", "The spark-domain-chip-labs module is not installed."],
"affected_workflow": "Telegram bot chip creation and user-facing error guidance"
},
"evidence": {
"safe_links_only": true,
"before_after_proof": "Before: /chip create returns chip-labs root not found with no guidance. After fix: error now shows a Repair section telling the user that spark-domain-chip-labs is required and to check agent.sparkswarm.ai for setup instructions. Fix verified in Telegram. Screenshots attached in linked issue.",
"links": ["https://github.com//issues/827"],
"forbidden": ["pdf", "zip", "exe", "unknown downloads", "shortened links", "archives", "binaries", "tokens", "browser cookies", "wallet material", "raw logs", "raw conversations", "raw memory", "raw patches", "private repo maps", "private scoring details"]
},
"proposed_fix": {
"approach": "Added a pre-flight check in createChipFromPrompt in chipCreate.ts that checks if chipLabsRoot exists before running the CLI. If not found, returns an actionable error with a Repair section explaining that spark-domain-chip-labs is required.",
"files_expected": ["src/chipCreate.ts"],
"tests_or_smoke": "Send /chip create a simple note taking app in Telegram with spark-domain-chip-labs not installed and verify the error shows the Repair section with install guidance."
},
"pr": {
"branch": "spark-compete/telegram-bot-chip-create-missing-module-guidance",
"title_prefix": "[spark-compete]",
"author_github": "Acone8",
"body_must_include": ["packet", "team", "pr_author", "repo", "actual_behavior", "expected_behavior", "repro_steps", "before_after_proof", "tests_or_smoke", "duplicate_notes", "risk_notes", "review_claim"],
"url": "#829"
},
"review_claim": {
"impact_claim": "medium",
"evidence_types": ["smoke_test", "redacted_conversation_excerpt"],
"duplicate_notes": "Searched open PRs and issues in vibeforge1111/spark-telegram-bot. No existing PR covers missing repair guidance for chip-labs root not found. Issue #827 documents this specific failure path.",
"risk_notes": "Change adds a pre-flight existsSync check in createChipFromPrompt before running the CLI. No secrets, CI workflows, auth controls, dependency files, or private repo maps changed.",
"review_state_requested": "pr_review"
}
}