[spark-compete] Fix: add repair guidance when /loop or /recursive start chip/path not found - #832
Open
Acone8 wants to merge 2 commits into
Conversation
Acone8
changed the title
NoRegretz
pushed a commit
to NoRegretz/spark-telegram-bot
that referenced
this pull request
Jul 1, 2026
vibeforge1111#836: when /recursive fails because the Swarm workspace is unconfigured, append a Repair block telling the user to set SPARK_SWARM_WORKSPACE_ID / SPARK_SWARM_ACCESS_TOKEN — gated by a /workspace is not configured|SPARK_SWARM/ match so unrelated failures are unaffected. vibeforge1111#832: append a "create a chip / list paths" Repair hint when a /loop or /recursive chip-loop fails. Per maintainer review the hint is now gated behind a not-found/path-missing match (mirroring 836's regex approach) instead of firing unconditionally, so timeouts and crashes no longer emit a misleading "run /chip create" instruction. PRs: vibeforge1111#836, vibeforge1111#832 Co-authored-by: Acone8 <Acone8@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#832",
"team": {
"name": "Syntax Layer",
"members": ["Acone8", "Kruz45", "Dabstil"],
"llm_device_holder": "Acone8",
"device_holder_github": "https://github.com/Acone8",
"github_accounts": ["Acone8", "Kruz45", "Dabstil"]
},
"target_repo": {
"id": "vibeforge1111/spark-telegram-bot",
"source": "https://github.com/vibeforge1111/spark-telegram-bot",
"owner_surface": "telegram-bot"
},
"issue": {
"type": "bug",
"severity": "medium",
"title": "/loop fails with Command failed when chip key not found - no repair guidance",
"actual_behavior": "Sending /loop nonexistent-chip 1 returns Loop failed: Command failed: [long python path] --chip nonexistent-chip with no guidance on what went wrong or how to fix it.",
"expected_behavior": "When /loop fails the error should show a Repair section telling the user to make sure the chip key exists and how to create one.",
"repro_steps": ["Send /loop nonexistent-chip 1 in Telegram.", "Observe: Loop failed: Command failed with no repair guidance."],
"affected_workflow": "Telegram bot loop command error handling and user-facing repair instructions"
},
"evidence": {
"safe_links_only": true,
"before_after_proof": "Before: /loop nonexistent-chip 1 returns Loop failed: Command failed with no guidance. After fix: error now shows a Repair section telling the user to make sure the chip key exists and run /chip create. Fix verified in Telegram. Screenshots attached in linked issue.",
"links": ["https://github.com//issues/831"],
"forbidden": ["pdf", "zip", "exe", "unknown downloads", "shortened links", "archives", "binaries", "tokens", "browser cookies", "wallet material", "raw logs", "raw conversations", "raw memory", "raw patches", "private repo maps", "private scoring details"]
},
"proposed_fix": {
"approach": "Added a Repair section to the loop error handler in index.ts that always shows when /loop fails, telling the user to verify the chip key exists and use /chip create to create a new chip.",
"files_expected": ["src/index.ts"],
"tests_or_smoke": "Send /loop nonexistent-chip 1 in Telegram and verify the error shows the Repair section with chip guidance."
},
"pr": {
"branch": "spark-compete/telegram-bot-loop-missing-chip-guidance",
"title_prefix": "[spark-compete]",
"author_github": "Acone8",
"body_must_include": ["packet", "team", "pr_author", "repo", "actual_behavior", "expected_behavior", "repro_steps", "before_after_proof", "tests_or_smoke", "duplicate_notes", "risk_notes", "review_claim"],
"url": "#832"
},
"review_claim": {
"impact_claim": "medium",
"evidence_types": ["smoke_test", "redacted_conversation_excerpt"],
"duplicate_notes": "Searched open PRs and issues in vibeforge1111/spark-telegram-bot. No existing PR covers missing repair guidance for /loop command failures. Issue #831 documents this specific failure path.",
"risk_notes": "Change adds a Repair hint string to the loop error handler. No secrets, CI workflows, auth controls, dependency files, or private repo maps changed.",
"review_state_requested": "pr_review"
}
}