Skip to content

[spark-compete] fix: restrict operator action file paths to allowed roots #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
binance1230 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[spark-compete] fix: restrict operator action file paths to allowed roots #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/operatorActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { promises as fs } from 'node:fs';
import path from 'node:path';
import os from 'node:os';

export type SafeOperatorAction =
| { kind: 'level5_smoke'; filePath: string }
Expand All @@ -16,6 +17,13 @@ function extractWindowsPath(text: string): string | null {
return rawPath.replace(/\s+\b(?:exists?|and|then)\b.*$/i, '').trim();
}

function isPathWithinAllowedRoot(filePath: string): boolean {
const resolved = path.resolve(filePath).toLowerCase();
const homeDir = os.homedir().toLowerCase();
const tmpDir = os.tmpdir().toLowerCase();
return resolved.startsWith(homeDir) || resolved.startsWith(tmpDir);
}

function isExpectedLevel5SmokePath(filePath: string): boolean {
const normalized = path.win32.normalize(filePath).toLowerCase();
return normalized.endsWith('\\appdata\\local\\temp\\spark-telegram-level5-smoke.txt');
Expand Down Expand Up @@ -56,6 +64,9 @@ export function parseSafeOperatorAction(text: string): SafeOperatorAction | null

export async function runSafeOperatorAction(action: SafeOperatorAction): Promise<string> {
if (action.kind === 'level5_smoke') {
if (!isPathWithinAllowedRoot(action.filePath)) {
return `Refused: path outside allowed roots (home or temp): ${action.filePath}`;
}
await fs.writeFile(action.filePath, 'level5 ok', 'utf8');
const contents = await fs.readFile(action.filePath, 'utf8');
await fs.unlink(action.filePath);
Expand All @@ -74,6 +85,9 @@ export async function runSafeOperatorAction(action: SafeOperatorAction): Promise
].join('\n');
}

if (!isPathWithinAllowedRoot(action.folderPath)) {
return `Refused: path outside allowed roots (home or temp): ${action.folderPath}`;
}
const entries = await fs.readdir(action.folderPath, { withFileTypes: true });
const folderNames = entries
.filter((entry) => entry.isDirectory())
Expand Down