Skip to content

[spark-compete] fix: validate previewUrl against private/reserved hosts before fetch #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yossweh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[spark-compete] fix: validate previewUrl against private/reserved hosts before fetch #843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7bbeee
fix: validate previewUrl against private/reserved hosts before fetch
0xchunk1 Jun 18, 2026
512786a
fix: update form-data to resolve CRLF injection audit
0xchunk1 Jun 18, 2026
2222453
fix: replace Tencent mirror URLs with standard npm registry in packag…
0xchunk1 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 21 additions & 0 deletions src/missionRelay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,7 +1234,28 @@ function previewLinkFromEvent(event: DeliverableRelayEvent): string | null {
return relayStringField(event.data, 'previewUrl') || relayStringField(event.data, 'preview_url');
}

function isPrivateOrReservedHost(hostname: string): boolean {
const lower = hostname.toLowerCase().replace(/^\[|\]$/g, '');
if (['127.0.0.1', 'localhost', '::1', '0.0.0.0'].includes(lower)) return true;
if (lower.startsWith('10.')) return true;
if (lower.startsWith('172.')) {
const second = parseInt(lower.split('.')[1], 10);
if (second >= 16 && second <= 31) return true;
}
if (lower.startsWith('192.168.')) return true;
if (lower.startsWith('169.254.')) return true;
if (lower === 'metadata.google.internal' || lower === 'metadata.google.com') return true;
if (lower.endsWith('.internal') || lower.endsWith('.local')) return true;
return false;
}

async function httpPreviewIsReachable(url: string): Promise<boolean> {
try {
const parsed = new URL(url);
if (isPrivateOrReservedHost(parsed.hostname)) return false;
} catch {
return false;
}
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), 2500);
const uiKey = process.env.SPARK_UI_API_KEY?.trim();
Expand Down
Loading