Skip to content

[spark-compete] fix(scheduler): scheduler _tick can relaunch the same record while its previous fire is still in flight #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4gjnbzb4zf-sudo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[spark-compete] fix(scheduler): scheduler _tick can relaunch the same record while its previous fire is still in flight #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/lib/server/scheduler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ interface StoreShape {
let _store: StoreShape | null = null;
let _tickTimer: NodeJS.Timeout | null = null;
let _starting = false;
const _firingIds = new Set<string>();

function _id(): string {
return 'sched-' + randomBytes(4).toString('hex');
Expand Down Expand Up @@ -323,7 +324,13 @@ async function _tick(): Promise<void> {
continue;
}
if (new Date(rec.nextFireAt) > now) continue;
if (_firingIds.has(rec.id)) {
// Previous fire for this schedule is still in flight (e.g. long subprocess).
// Skip so we do not relaunch the mission or emit a duplicate relay message.
continue;
}
const nextFireAt = _computeNext(rec.cron, rec.timezone);
_firingIds.add(rec.id);
try {
const result = await _fire(rec);
rec.lastFiredAt = new Date().toISOString();
Expand All @@ -334,6 +341,8 @@ async function _tick(): Promise<void> {
rec.lastFiredAt = new Date().toISOString();
rec.fireCount += 1;
rec.lastStatus = 'crash: ' + errorMessage(err);
} finally {
_firingIds.delete(rec.id);
}
rec.nextFireAt = nextFireAt;
dirty = true;
Expand Down