Skip to content

[spark-compete] fix(security): validate workingDirectory in dispatch endpoint to prevent arbitrary cwd for spawned processes #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ifeoluwaaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[spark-compete] fix(security): validate workingDirectory in dispatch endpoint to prevent arbitrary cwd for spawned processes #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/routes/api/dispatch/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { json } from '@sveltejs/kit';
import type { RequestHandler } from './$types';
import { env } from '$env/dynamic/private';
import { requireControlAuth, enforceRateLimit } from '$lib/server/mcp-auth';
import { sparkWorkspaceRoot, isWithinDirectory, externalProjectPathsAllowed } from '$lib/server/spark-run-workspace';
import { eventBridge } from '$lib/services/event-bridge';
import { providerRuntime } from '$lib/server/provider-runtime';
import { DEFAULT_MULTI_LLM_PROVIDERS } from '$lib/services/multi-llm-orchestrator';
Expand Down Expand Up @@ -79,6 +80,18 @@ export const POST: RequestHandler = async (event) => {
const body = await event.request.json();
const { executionPack, apiKeys, workingDirectory, relay } = body;

// Validate workingDirectory stays within allowed workspace root
if (typeof workingDirectory === 'string' && workingDirectory.trim()) {
const trimmedWorkingDir = workingDirectory.trim();
const workspaceRoot = sparkWorkspaceRoot();
if (!externalProjectPathsAllowed() && !isWithinDirectory(workspaceRoot, trimmedWorkingDir)) {
return json(
{ success: false, error: `workingDirectory must be within workspace root (${workspaceRoot}). Received: ${trimmedWorkingDir}` },
{ status: 400 }
);
}
}

if (!executionPack || !executionPack.providers || !Array.isArray(executionPack.providers)) {
return json({ success: false, error: 'Invalid execution pack' }, { status: 400 });
}
Expand Down