[spark-compete] fix(welcome): PRD bridge requestId uses Math.random — weak entropy - #864
Open
TALLSOME24 wants to merge 5 commits into
Open
[spark-compete] fix(welcome): PRD bridge requestId uses Math.random — weak entropy#864TALLSOME24 wants to merge 5 commits into
TALLSOME24 wants to merge 5 commits into
Conversation
The Missions page renders a 'paused' status badge but did not let users filter by it — paused missions only appeared under 'all'. The Mission status enum includes 'paused', so the filter row should too.
…unning missions When a running mission had no task breakdown yet, taskProgressPercent returned a literal 48, misleading operators about real progress. Return 0 so the UI's hasTaskProgress path renders an indeterminate state.
completionEvidenceTooltipForDisplay was returning a generic "Completion proof is incomplete." and dropping the server-built evidence.summary that already names which specific pieces are missing. Now we fall back to evidence.summary first, then the generic string.
Word/Excel/PowerPoint create temporary lockfiles (~$*) whenever an Office document is open. These should never be committed. A previous commit on this repo accidentally committed `~$ark_Railway_Setup_Guide.docx` when a Word document in the repo root was open during a git add. The committed lockfile was subsequently removed, but the gitignore pattern that would have prevented it was not added. This patch adds the pattern so the recurrence is blocked.
Replace Math.random() with crypto.randomUUID() for PRD request ID. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#864",
"team": {"name": "The Spark Plug", "members": ["TALLSOME24","Mrsankalove","Klausabdul"], "llm_device_holder": "TALLSOME24", "device_holder_github": "https://github.com/TALLSOME24", "github_accounts": ["TALLSOME24","Mrsankalove","Klausabdul"]},
"target_repo": {"id": "vibeforge1111/vibeship-spawner-ui", "source": "https://github.com/vibeforge1111/vibeship-spawner-ui", "owner_surface": "spawner-ui"},
"issue": {"type": "security_concern", "severity": "medium", "title": "Welcome.svelte PRD bridge requestId uses Math.random — weak entropy", "actual_behavior": "At Welcome.svelte:125 the PRD bridge requestId is built with Math.random().toString(36), a non-cryptographic PRNG that provides insufficient entropy for request identifiers.", "expected_behavior": "PRD bridge requestId should use crypto.randomUUID() for collision-resistant, cryptographically random identifiers.", "repro_steps": ["Observe requestId construction at Welcome.svelte:125.", "Note it calls Math.random() instead of crypto.randomUUID()."], "affected_workflow": "PRD bridge request ID generation in Welcome.svelte handlePRDUpload"},
"evidence": {"safe_links_only": true, "before_after_proof": "Before: prd-${Date.now()}-${Math.random()...}. After: prd-${crypto.randomUUID()}.", "links": ["https://github.com//pull/864/files"], "forbidden": ["pdf","zip","exe","unknown downloads","shortened links","archives","binaries","tokens","browser cookies","wallet material","raw logs","raw conversations","raw memory","raw patches","private repo maps","private scoring details"]},
"proposed_fix": {"approach": "Replace Math.random() with crypto.randomUUID() in PRD bridge requestId construction.", "files_expected": ["src/lib/components/Welcome.svelte","tests/test_welcome_prd_id.test.ts"], "tests_or_smoke": "5 tests verify UUID format, no Math.random, 1000 unique IDs."},
"pr": {"branch": "fix/welcome-prd-crypto-id-main", "title_prefix": "[spark-compete]", "author_github": "TALLSOME24", "body_must_include": ["packet","team","pr_author","repo","actual_behavior","expected_behavior","repro_steps","before_after_proof","tests_or_smoke","duplicate_notes","risk_notes","review_claim"], "url": "https://github.com/vibeforge1111/vibeship-spawner-ui/pull/864"},
"review_claim": {"impact_claim": "medium", "evidence_types": ["failing_test","passing_test","smoke_test"], "duplicate_notes": "No prior PR addressed Welcome.svelte PRD requestId entropy.", "risk_notes": "ID format changes from timestamp-based to UUID.", "review_state_requested": "pr_review"}
}