[spark-compete] fix(canvas-store): connection IDs use Math.random at 4 sites — weak entropy - #867
Open
TALLSOME24 wants to merge 5 commits into
Open
Conversation
The Missions page renders a 'paused' status badge but did not let users filter by it — paused missions only appeared under 'all'. The Mission status enum includes 'paused', so the filter row should too.
…unning missions When a running mission had no task breakdown yet, taskProgressPercent returned a literal 48, misleading operators about real progress. Return 0 so the UI's hasTaskProgress path renders an indeterminate state.
completionEvidenceTooltipForDisplay was returning a generic "Completion proof is incomplete." and dropping the server-built evidence.summary that already names which specific pieces are missing. Now we fall back to evidence.summary first, then the generic string.
Word/Excel/PowerPoint create temporary lockfiles (~$*) whenever an Office document is open. These should never be committed. A previous commit on this repo accidentally committed `~$ark_Railway_Setup_Guide.docx` when a Word document in the repo root was open during a git add. The committed lockfile was subsequently removed, but the gitignore pattern that would have prevented it was not added. This patch adds the pattern so the recurrence is blocked.
…ntropy Replace all 4 Math.random() connection ID sites with crypto.randomUUID() in canvas.svelte.ts (addNodesWithConnections, duplicateNodes, pasteFromClipboard, addConnection). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ifeoluwaaj
pushed a commit
to ifeoluwaaj/vibeship-spawner-ui
that referenced
this pull request
Jun 27, 2026
…e/ID sites Same-author entropy-hardening series, reduced to the disclosed security lines per review (all undisclosed UX/gitignore/test hunks stripped — most were already independently landed on the base branch): - creator-mission saveCreatorMissionTrace: atomic-write temp path no longer embeds process.pid+Date.now() (predictable -> symlink pre-emption); use randomUUID() with the codebase's node:crypto import convention (vibeforge1111#825) - provider-runtime persist: same predictable temp-path fix, randomUUID() via node:crypto import (vibeforge1111#826) - canvas store: the 4 connection-ID sites switch from Math.random().toString(36) to crypto.randomUUID() Web Crypto global (vibeforge1111#867) Per review notes: took ONLY the security lines, used the node:crypto randomUUID import (not a bare crypto. global) in the server files, and discarded the tautological re-implementation tests. Co-authored-by: TALLSOME24 <TALLSOME24@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{
"schema": "spark-compete-hotfix-v1",
"event": "spark-compete-first-event",
"submission_mode": "public_repo_pr",
"submission_target_url": "#867",
"team": {"name": "The Spark Plug", "members": ["TALLSOME24","Mrsankalove","Klausabdul"], "llm_device_holder": "TALLSOME24", "device_holder_github": "https://github.com/TALLSOME24", "github_accounts": ["TALLSOME24","Mrsankalove","Klausabdul"]},
"target_repo": {"id": "vibeforge1111/vibeship-spawner-ui", "source": "https://github.com/vibeforge1111/vibeship-spawner-ui", "owner_surface": "spawner-ui"},
"issue": {"type": "security_concern", "severity": "medium", "title": "canvas.svelte.ts connection IDs use Math.random at 4 call sites — weak entropy", "actual_behavior": "At canvas.svelte.ts lines 273, 440, 496, 526, connection IDs are built with Math.random().toString(36).slice(2,10), a non-cryptographic PRNG providing insufficient entropy for canvas connection identifiers.", "expected_behavior": "All connection ID generation sites should use crypto.randomUUID() for collision-resistant identifiers.", "repro_steps": ["Observe connection ID construction at canvas.svelte.ts lines 273, 440, 496, 526.", "Note all 4 call sites use Math.random() instead of crypto.randomUUID()."], "affected_workflow": "Canvas store connection ID generation (addNodesWithConnections, duplicateNodes, pasteFromClipboard, addConnection)"},
"evidence": {"safe_links_only": true, "before_after_proof": "Before: 'conn-' + Math.random()... at 4 sites. After: 'conn-' + crypto.randomUUID() at all 4 sites.", "links": ["https://github.com//pull/867/files"], "forbidden": ["pdf","zip","exe","unknown downloads","shortened links","archives","binaries","tokens","browser cookies","wallet material","raw logs","raw conversations","raw memory","raw patches","private repo maps","private scoring details"]},
"proposed_fix": {"approach": "Replace all 4 Math.random() connection ID sites with crypto.randomUUID() in canvas.svelte.ts.", "files_expected": ["src/lib/stores/canvas.svelte.ts","tests/test_canvas_store_conn_id.test.ts"], "tests_or_smoke": "5 tests verify UUID format, no Math.random, 1000 unique IDs."},
"pr": {"branch": "fix/canvas-store-conn-crypto-id-main", "title_prefix": "[spark-compete]", "author_github": "TALLSOME24", "body_must_include": ["packet","team","pr_author","repo","actual_behavior","expected_behavior","repro_steps","before_after_proof","tests_or_smoke","duplicate_notes","risk_notes","review_claim"], "url": "https://github.com/vibeforge1111/vibeship-spawner-ui/pull/867"},
"review_claim": {"impact_claim": "medium", "evidence_types": ["failing_test","passing_test","smoke_test"], "duplicate_notes": "No prior PR addressed canvas.svelte.ts connection ID entropy.", "risk_notes": "ID format changes from counter+random to UUID; connection lookup by ID still works.", "review_state_requested": "pr_review"}
}